Closed
Bug 583608
Opened 14 years ago
Closed 13 years ago
warning: ‘const char* GetMIMEType(nsIPluginInstance*)’ defined but not used in nsObjectFrame.cpp
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: jdm, Assigned: dholbert)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 1 obsolete file)
|
2.07 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [build_warning]
|
Assignee | |
Comment 1•13 years ago
|
||
There are now 3 "defined but not used [on linux]" warnings for this file:
> layout/generic/nsObjectFrame.cpp:1975: warning: 'void DrawPlugin(mozilla::layers::ImageContainer*, void*)' defined but not used
> layout/generic/nsObjectFrame.cpp:1983: warning: 'void OnDestroyImage(void*)' defined but not used
> layout/generic/nsObjectFrame.cpp:2787: warning: 'const char* GetMIMEType(nsIPluginInstance*)' defined but not used
These functions are only called in #ifdef XP_MACOSX blocks, so the function definitions themselves should be #ifdef XP_MACOSX.|
|
Assignee | |
Comment 2•13 years ago
|
||
This should do it. Testing locally & on tryserver as a cross-platform sanity-check.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•13 years ago
|
||
Ah, tryserver told me that the previous patch had neglected to notice an #ifdef XP_WIN spot where "::GetMIMEType" is called. This version tweaks the GetMIMEType ifdef to build if we're on XP_MACOSX or XP_WIN. This passed on TryServer.
Attachment #527558 -
Attachment is obsolete: true
Attachment #527643 -
Flags: review?(joshmoz)
Attachment #527643 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/29ea216a4153
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•