583748 - Add new UI to the save button for recording an optional name and comment

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P3)

Description

[Piotr Zalewa [:zalun]]

Submenu
---------

         +-----+------+---+--------
         | ... | Menu | v | ...
         +-----+------+---+------+-
               | MenuSubitem1    |
               | MenuSubItem2    |
               | ...             |
               | MenuSubItemN    |
               +-----------------+

Menu item might be an active link or not. If active it should link with the page which is extending the dropdown list. In example Revisions could show latest N revisions on hover and on click display a RevisionsPage with all revisions of the package.

MenuItem Panel
--------------
Proposed for the [Save] menu item.

        ----+------+---+-----
        ... | Save | v | ...
        ----+------+---+--------------+
            | Version: (1.5.rev57)    |
            | +---------------------+ |
            | |                     | |
            | +---------------------+ |
            | Comment:                |
            | +---------------------+ |
            | |                     | |
            | |                     | |
            | |                     | |
            | |                     | |
            | +---------------------+ |
            +-------------------------+

Comment 1

[Piotr Zalewa [:zalun]]

An explanation for the MenuItem Panel.

The panel is shown on hover the [v] element. It should be submitted after clicking in the menu item.

Comment 2

[Daniel Buchner [:dbuc]]

Changed the bug title to better reflect the goal of the feature.

Comment 3

[Piotr Zalewa [:zalun]]

fixed

Comment 4

[Daniel Buchner [:dbuc]]

There are a few bugs and usability items that need to be addressed before this bug can be resolved and the feature is able to be included:

- The styles should match this implementation, it allows the element to be fluid while disallowing the textarea to be shrunken to the point that it is smaller than the intended min-width: http://jsfiddle.net/csuwldcat/9jHcF/20/

- The text in both the input and textarea is not selectable and should be

- The right border is missing on the latest version of the element on master

Comment 5

[Daniel Buchner [:dbuc]]

Also the alignment of the element is off from the save button on both Windows and Linux

Comment 6

[Daniel Buchner [:dbuc]]

The reason that the text inside the inputs is not selectable with the mouse or keyboard is due to the style "-moz-user-select: none;" that is set on the menu UL parent element.

Comment 7

[Piotr Zalewa [:zalun]]

fixed

Comment 8

[Daniel Buchner [:dbuc]]

Being that the save commit box is show on css :hover, let's make the default height and width of the form at least twice as big so as to prevent false-positive mouseouts of the element when adding text.

Comment 9

[Piotr Zalewa [:zalun]]

fixed