583782 - [OOPP] Generic "Program" icon on taskbar when watching full screen video

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[HotdogStorm]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8

The plugin-container.exe file has no icon associated with it so Windows shows the generic program icon.  It is also not grouped with other Firefox windows when combining is enabled.  Aero preview works properly with the new window.

Reproducible: Always

Steps to Reproduce:
1. Have multiple monitors connected
2. Place Firefox and the Windows taskbar on separate monitors
3. Run flash (eg. video) in full screen mode
Actual Results:  
A new taskbar entry is created for the fullscreen video, separated from other Firefox windows and showing the generic program icon.

Expected Results:  
A new taskbar entry should be created with an appropriate icon for easy identification, and it should be properly grouped with other Firefox windows.

Comment 1

[Asa Dotzler [:asa]]

If we think fullscreen plugin use on multi-monitor (or laptop plus external monitor) is sufficiently common, then we should fix this. It's quite ugly that we spawn a separate, un-branded taskbar item when in fullscreen flash plugins.

Comment 2

[Benjamin Smedberg]

I don't think this is common enough to block. Also, I don't think we would want to use the Firefox icon for plugin-container anyway, but some other utility/addon icon. cc'ing faaborg for thoughts.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Ideally this window should group with Firefox, under the Firefox icon.  From the user's perspective they are using their browser in full screen, they don't know if a site like Hulu is implemented using Flash or HTML5, just that it is on the Web.  Adding keyword ux-implementation-level

>I don't think this is common enough to block.

I agree, although it's too bad we don't have numbers on multiple monitor usage, it would be interesting to know how commonly the user might see this.

Comment 4

[Benjamin Smedberg]

I don't know whether we can make it group: jmathies, is there a way we can make two separate binaries group together in the task bar? I remember something about application IDs a while back, but I don't remember what happened with it.

Comment 5

[Jim Mathies [:jimm]]

The grouping should be working in 4.0. We never added win7 taskbar support to 3.6, but I suppose we could back port some of the work:

Bug 568904 - Don't perform a shell refresh when there are no shortcuts for the installation when updating app modal id's. r=jmathies, a=approval2.0 
Bug 563381 - Sync AppUserModelID with plugin-container. r=bsmedberg.
Bug 562753 - On upgrade, update AppUserModelID for application shortcuts. r=rstrong.
Bug 526663 - Remove pinned shortcuts after uninstalling application. r=rstrong.
Bug 521141 - Group running applications properly under shortcuts pinned to the taskbar. r=rstrong.
Bug 505925 - Set Win7 AppUserModelID based on application.ini settings. r=neil, sr=roc.

Comment 6

[Benjamin Smedberg]

HotDogStorm, can you try this with Firefox 4 beta, available from http://www.mozilla.com/en-US/firefox/all-beta.html ?

Comment 7

[HotdogStorm]

> HotDogStorm, can you try this with Firefox 4 beta, available from
> http://www.mozilla.com/en-US/firefox/all-beta.html ?

I installed Beta 6 with a clean profile and the taskbar entry for fullscreen flash movies did not group with the main firefox windows.

Comment 9

[Jim Mathies [:jimm]]

I'll confirm bug 563381 is still working here.

Comment 10

[Jim Mathies [:jimm]]

(In reply to comment #9)
> I'll confirm bug 563381 is still working here.

So this is working properly on single monitor systems. The registration succeeds and secondary windows thrown up (MessageBox for example) group properly with the parent process.

This must be something unique to dual monitor systems. I'd suggest we morph this bug into getting the default application icon inserted into the plugin container exe so things look right.

Comment 11

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.