583941 - testDisabledElements.js uses newly deprecated function

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Andrew Halberstadt [:ahal]]

A change which rolls 'assertPropertyNotExist()' into 'assertNotProperty()' was just checked into Mozmill 1.4.2.

testPrivateBrowsing/testDisabledElements.js was the only test that used this function.

To fix: s/assertPropertyNotExist/assertNotProperty/

Note that the old function wasn't removed for 1.4.2, so tests that use it will still work, but will see a deprecation warning in the logs.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aaron, could you update the test accordingly?

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - assertNotProperty

s/assertPropertyNotExist/assertNotProperty/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 462378 [details] [diff] [review]
Patch v1 - assertNotProperty

Remind me to check this in once Mozmill 1.4.2 has been released.

Comment 4

[Andrew Halberstadt [:ahal]]

As per the discussion in our weekly meeting this should be changed to either assertNotDOMProperty or assertNotJSProperty instead.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aaron, can you please do that change and also create a new bug for moving all of our assertJS function calls which check attributes on nodes to assertNotJSProperty/assertJSProperty? Thanks.

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Patch - assertNotDOMProperty

s/assertNotProperty/assertNotDOMProperty

I've never seen this function before so I'm assuming it's the same parameters and usage.

Comment 7

[Aaron Train [:aaronmt]]

(In reply to comment #5)
> Aaron, can you please do that change and also create a new bug for moving all
> of our assertJS function calls which check attributes on nodes to
> assertNotJSProperty/assertJSProperty? Thanks.

Can you please explain what assertNotJSProperty is, and an example of where you are looking to use it.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 463336 [details] [diff] [review]
Patch - assertNotDOMProperty

>-  controller.assertPropertyNotExist(importHTML, "disabled");
>+  controller.assertNotDOMProperty(importHTML, "disabled");

assertProperty has been replaced by assertJSProperty which directly checks for the property of the given JS object. AssertDOMProperty will check the DOM attribute instead. That said the above code should use assertNotJSProperty.

Comment 9

[Aaron Train [:aaronmt]]

Attachment: Patch - Deprecation fixes on assert methods

Hopefully I got this right. Apologize, was confused with the name changes and adjusting to the different names, it wasn't clear at first.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fixed by bug 584575.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.