Closed Bug 584480 Opened 14 years ago Closed 14 years ago

Referrer header missing from video (and audio) requests

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- final+
status2.0 --- wanted
status1.9.2 --- wanted
status1.9.1 --- wanted

People

(Reporter: remy, Assigned: cajbir)

References

(
URL
)

Details

(Whiteboard: [sg:want] server dos-prevention)

Attachments

(1 file, 3 obsolete files)

Rolled up and rebased patch
6.30 KB, patch
cajbir
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_3; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.125 Safari/533.4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6

All http in the browser send a referrer header, except the new video, source and audio elements.  This means that we can't prevent someone from hotlinking the content from a site by using a simple referral check technique.

This recently took down my server because a very high traffic site was linking directly to the video and the server couldn't cope.  I should have been able to prevent it from continuing by preventing hotlinking, but there's no referrer header being sent (all other headers are fine).  Opera does this correctly and sends the headers.

The result was I had to remove the video entirely from http://html5demos.com/video

Reproducible: Always

Steps to Reproduce:
Run this HTML and inspect the request headers in Firebug - a plain image and script are there for reference:

<!DOCTYPE html> 
<title>video refer test</title> 
<body>
<img src="image-for-reference" /> 
<video src="video-via-src-attribute"></video> 
<video> 
  <source src="video-via-src-element"></source> 
</video> 
<script src="script-for-reference"></script>
</body>
Actual Results:  
No referrer headers on the video, but we do have them on the image and script.

Expected Results:  
Correct referrers for media elements.
This is a valid bug and an important anti-abuse feature as described above.
Blocks: 61660
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
status1.9.1: --- → wanted
status1.9.2: --- → wanted
status2.0: --- → wanted
Component: General → Video/Audio
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → video.audio
Whiteboard: [sg:want] server dos-prevention
Version: unspecified → Trunk
OS: Mac OS X → All
Assignee: nobody → chris.double

        Attachment #465058 -
        Flags: review?(roc)

    
    

    
  
Comment on attachment 465058 [details] [diff] [review]
Send Referer header with media requests

Could use a test

        Attachment #465058 -
        Flags: review?(roc) → review+

    
  
blocking2.0: ? → final+

    
  
Flags: in-testsuite?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Test that referer is sent (obsolete)
        — 
          — Splinter Review
      

    


  
For the test I have an sjs that checks the referer. If it exists then it returns a video otherwise it returns a 404.

        Attachment #475592 -
        Flags: review?(roc)

    
    

    
  
The test is only going to work if Ogg is enabled. I think you could take the filename as a query parameter in the URL, then the test JS can select a file name that's supported and pass that to the sjs.

    
    

    
  
Yeah I did it this way because we took the same approach in another bug after discussion that we always have ogg enabled in our test machines.

    
    

    
  
I'll change it to not need any specific backend.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Test that referer is sent (obsolete)
        — 
          — Splinter Review
      

    


  
Changes test to iterate through one of the manifest list of files, looks for only those we can play and tests referer on them.

        Attachment #475592 -
        Attachment is obsolete: true

        Attachment #475705 -
        Flags: review?(roc)

        Attachment #475592 -
        Flags: review?(roc)

    
    

    
  


  
Rolled up patch and rebased to trunk. Carried r+ forward.

        Attachment #465058 -
        Attachment is obsolete: true

        Attachment #475705 -
        Attachment is obsolete: true

        Attachment #475898 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/bd0adbe793f3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: