Closed
Bug 584663
Opened 14 years ago
Closed 14 years ago
Image compositing stopped working (regressed between July 30 and July 31)
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta4+ |
People
(Reporter: bugzilla1, Assigned: bas.schouten)
References
Details
(Keywords: regression, testcase)
Attachments
(2 files)
74.06 KB,
text/html
|
Details | |
918 bytes,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
See attached testcase. Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c5f35032f22d&tochange=f73e5032cfad
Comment 1•14 years ago
|
||
Narrowed Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc00ee24a25c&tochange=4a3e8596e8fc Changeset 4a3e8596e8fc of Bug 576169 causes the problem
Blocks: 576169
Updated•14 years ago
|
blocking2.0: --- → ?
Assignee | ||
Comment 2•14 years ago
|
||
The old code did a Clip(gfxRectangle), this function call destroys the current path. The new code did not in any way clear the current path, therefor certain sequences of calls could cause an incorrect path to end up being sent to fill. Clearing the path before calling fill like the other methods do indirectly fixes this.
Comment on attachment 463203 [details] [diff] [review] Clear path before drawing image Needs a test, if we didn't catch this any other way.
Attachment #463203 -
Flags: review?(vladimir) → review+
blocking2.0: ? → beta4+
Assignee | ||
Comment 4•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/f5834a658fe2. Leaving this open until we've added a test.
Assignee | ||
Comment 5•14 years ago
|
||
I'm resolving this since it's showing as a Beta4 blocker. And the test isn't blocking Beta4.
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•