584752 - Make Modern work nicely with places bookmarks work

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Robert Kaiser]

Bug 580660 at least, maybe other places bookmarks work, introduces some Classic theme changes that should be ported in a reasonable way to Modern.

Comment 1

[Robert Kaiser]

Attachment: v1: Modern changes for places bookmarks

Here's a patch that should get everything my places bookmarks patches do to modern. The Classic parts matching this are done in bug 580660 and bug 580662. I copied the icons from there and modified them to match the Modern color scheme as well as I could.

Comment 2

[Ian Neal]

We should be trying to at least match classic for a3, so blocking for the moment.

Comment 3

[Ian Neal]

Comment on attachment 463952 [details] [diff] [review]
v1: Modern changes for places bookmarks

Could you make sure either the existing follow-up bugs for classic also cover modern or you have parallel follow-up bugs for modern. Thanks.

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> Could you make sure either the existing follow-up bugs for classic also cover
> modern or you have parallel follow-up bugs for modern. Thanks.

Sure, my plans are to address both Classic and Modern in sync in bug 585601.

Comment 5

[Robert Kaiser]

Pushed the patch as http://hg.mozilla.org/comm-central/rev/f8a85fd368e3

Comment 6

[[e-mail]]

(In reply to comment #4)
> (In reply to comment #3)
> > Could you make sure either the existing follow-up bugs for classic also cover
> > modern or you have parallel follow-up bugs for modern. Thanks.
> Sure, my plans are to address both Classic and Modern in sync in bug 585601.
Any nits will almost certainly apply equally to both themes.