5848 - oji does not build when the nspr-version of the tree is used

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P3)

Description

[Andreas Otte]

In mozilla/modules/oji/src/Makefile.in the variable NSPR_INCLUDE_DIR is used to
get some files included from mozilla/dist/include/private. When using NSPR from
the tree this variable is not defined and this files (primpl.h,...) are not
found.

Comment 1

[Alex Musil]

Reassigning all OJI bugs to [e-mail]

Comment 2

[edburns]

From: Ed Burns <[e-mail]>
To: [e-mail]
Subject: NSPR in tree ifdef?
Reply-To: Ed Burns <[e-mail]>
FCC: ~/.mail/sent-mail
--text follows this line--
Hi Daniel,

I'm looking at a bug, http://bugzilla.mozilla.org/show_bug.cgi?id=5848,
that says:

In mozilla/modules/oji/src/Makefile.in the variable NSPR_INCLUDE_DIR is
used to get some files included from mozilla/dist/include/private. When
using NSPR from the tree this variable is not defined and this files
(primpl.h,...) are not found.

I understand the problem, but am not sure which solution to take.

I could modify the Makefile.in to say:

INCLUDES +=		-I$(NSPR_INCLUDE_DIR)/private \
	-I$(DEPTH)/nsprpub/pr/include/private,

but I'd rather do something like this:

ifdef MOZ_USE_TREE_NSPR
INCLUDES +=		-I$(DEPTH)/nsprpub/pr/include/private,
else
INCLUDES +=		-I$(NSPR_INCLUDE_DIR)/private
endif

Is this possible?

Thanks,

Ed

Comment 3

[edburns]

*** Bug 7287 has been marked as a duplicate of this bug. ***

Comment 4

[justin hugh daly]

the problem may be with autoconf? in my autoconf.mk NSPR_INCLUDE_DIR in not
defined. i was able to make it work by changing NSPR_INCLUDE_DIR to PUBLIC --
which is defined correctly in config.mk

Comment 5

[edburns]

Well, I know NSPR_INCLUDE_DIR isn't defined, but you're telling me that PUBLIC
is, and that answers my question.  I believe this gives me enough information to
fix the bug.

Thanks,

Ed

Comment 6

[edburns]

This bug was fixed by [e-mail] on 8/9/99.  Thanks, I guess.  Though I
would have liked to have known about the change before you made it.

Comment 7

[Paul Wyskoczka]

This is a developer bug.  Verifing