584812 - Master password prompt is too narrow

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Matthew N. [:MattN]]

Attachment: Master password dialog size vs. window size

A recent change on trunk causes the master password prompt to be small/narrow.  I believe I first experienced it yesterday 20100804.  I am currently running:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b4pre) Gecko/20100805 Minefield/4.0b4pre

I launch Minefield at then navigate to a website where I have a saved password and when the master password dialog appears, it is much narrower than before which makes it harder to tell if you bump an extra key on the keyboard while typing your password.  This happens in safe mode as well and my window is not unusually small (see screenshot).

Comment 1

[:Felipe Gomes (needinfo for replies!)]

The problem was fixed by the patch on bug 593307. It happened when the top-left corner of the browser window was at a negative X/Y position.

That bug and this one were both regressions from bug 520805, which made windows to be sometimes created offscreen. It wasn't a problem per se, but the new patch prevents that, as there are some places in the code didn't handle that case well.
(Maybe that's a reasonable pre-condition as this has always been the case before, or maybe not and we should get a follow-up bug to investigate that).