Closed
Bug 584947
Opened 14 years ago
Closed 14 years ago
Make simplejson available in python 2.5.x installation for linux and macosx
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
(Whiteboard: [buildslaves][puppet])
Attachments
(5 files)
561 bytes,
text/plain
|
bhearsum
:
review+
rail
:
checked-in+
|
Details |
1.53 KB,
text/plain
|
bhearsum
:
review+
rail
:
checked-in+
|
Details |
601 bytes,
text/plain
|
bhearsum
:
review+
|
Details |
595 bytes,
text/plain
|
bhearsum
:
review+
|
Details |
4.06 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Bug 555205 requires json (available in Python 2.6) or simplejson for 2.5.1. Default Python used for builds is 2.5.1 but simplejson is not available on linux{,64} and macosx{,64} platforms. catlee suggested to install simplejson to 2.5.1, what IMO should be done by separate RPM/DMG packages. Please see attached RPM specs (setuptools is a build time requirement, we don't need it to be installed on the build slaves).
Attachment #463429 -
Flags: review?(bhearsum)
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #463430 -
Flags: review?(bhearsum)
Assignee | ||
Comment 2•14 years ago
|
||
TODO: DMG build instructions and puppet manifests.
Assignee | ||
Comment 3•14 years ago
|
||
setup-tools-create-dmg.sh creates a DMG pkg for darwin9 machines and uses /tools/python as a default python. This packages only needed for creating simplejson package and there is no need to install it on every machine.
Attachment #464003 -
Flags: review?(bhearsum)
Assignee | ||
Comment 4•14 years ago
|
||
simplejson-create-dmg.sh creates simplejson DMG using /tools/python hierarchy (not versioned).
Attachment #464004 -
Flags: review?(bhearsum)
Assignee | ||
Updated•14 years ago
|
Summary: Make simlejson available in python 2.5.1 installation for linux and macosx → Make simlejson available in python 2.5.x installation for linux and macosx
Assignee | ||
Comment 5•14 years ago
|
||
simplejson-2.1.1-py25.dmg is for darwin9 machines only. Darwin10 machines have 2.6.4 with json module afaik.
Attachment #464005 -
Flags: review?(bhearsum)
Comment 6•14 years ago
|
||
Comment on attachment 463430 [details]
setuptools RPM spec
Mostly copied from upstream, which is great, looks fine.
Attachment #463430 -
Flags: review?(bhearsum) → review+
Updated•14 years ago
|
Attachment #463429 -
Flags: review?(bhearsum) → review+
Comment 7•14 years ago
|
||
Comment on attachment 464003 [details]
setup-tools-create-dmg.sh
Why does this script install it, too?
Updated•14 years ago
|
Attachment #464005 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > Why does this script install it, too? Just to record every step I've done on the slave. We're going to use only the generated DMG files in production.
Updated•14 years ago
|
Attachment #464003 -
Flags: review?(bhearsum) → review+
Updated•14 years ago
|
Attachment #464004 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 9•14 years ago
|
||
Comment on attachment 463429 [details] simplejson RPM spec http://hg.mozilla.org/build/rpm-sources/rev/c7d1648cdb8e
Attachment #463429 -
Flags: checked-in+
Assignee | ||
Comment 10•14 years ago
|
||
Comment on attachment 463430 [details] setuptools RPM spec http://hg.mozilla.org/build/rpm-sources/rev/c7d1648cdb8e
Attachment #463430 -
Flags: checked-in?
Assignee | ||
Comment 11•14 years ago
|
||
Comment on attachment 463430 [details] setuptools RPM spec http://hg.mozilla.org/build/rpm-sources/rev/c7d1648cdb8e
Assignee | ||
Updated•14 years ago
|
Attachment #463430 -
Flags: checked-in? → checked-in+
Assignee | ||
Comment 12•14 years ago
|
||
Staging run was successful for the targeted 3 platforms. I copied the binaries (excluding setuptools) to /N/production, so the manifest patch is ready for deployment.
Assignee | ||
Updated•14 years ago
|
Summary: Make simlejson available in python 2.5.x installation for linux and macosx → Make simplejson available in python 2.5.x installation for linux and macosx
Assignee | ||
Comment 13•14 years ago
|
||
Comment on attachment 464005 [details] [diff] [review] Puppet manifest http://hg.mozilla.org/build/puppet-manifests/rev/00b3f88d1ec0 mpt-production-puppet, mv-production-puppet and staging-puppet servers are updated as well.
Attachment #464005 -
Flags: checked-in+
Assignee | ||
Comment 14•14 years ago
|
||
simplejson is available as expected on randomly checked linux, linux64 and darwin9 build slaves.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•