585101 - Application fails in FF4 due to setting a property on DOM node of "hidden"

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[nemo]

http://m8y.org/js/solitaire.xhtml was a page I made quite a few years ago just to muck about w/ unicode, which I'd just discovered had all those nifty glyphs (kinda like chess.xhtml in that same dir).

Recently, I accessed that file in FF4b nightly and noticed that it was no longer rendering all the table cells as it does in FF3.6 and other browsers.

Tentatively going with a regression although I'm not sure what the cause is since this is admittedly not a reduced page.

Hoping someone could say at a glance what happened.  Could it be because I used a table?  I thought it'd be cute to render a small deck of cards for browsers if javascript was not enabled.

Filing this in the wrong product due to a recently added (past year?) flaw in Bugzilla's bug reporting template when using a non-javascript browser. My apologies. Hopefully it'll be eventually fixed.

Comment 1

[Justin Lebar (not reading bugmail)]

Is it valid to set the "hidden" attribute on a DOM node?  That's not a real attribute IIRC.  Since it's XHTML, we're probably rejecting it as invalid.

At least, the hidden attribute doesn't show up in Firebug, but it does show up in Chrome.

Comment 2

[nemo]

Those attributes are just added to the DOM node in javascript.  Nothing illegal about that.
deck[i].hidden = false;
They are not part of the actual XML when Firefox parses the page.

http://validator.w3.org/check?uri=http%3A%2F%2Fm8y.org%2Fjs%2Fsolitaire.xhtml&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 3

[Justin Lebar (not reading bugmail)]

If you can make a minimized testcase, it might make it clearer what's going on.

Comment 4

[nemo]

Ok, I think I hit on the key difference, half-way through reducing...
http://m8y.org/js/sol_reduce.xhtml   Different in FF4 vs FF3.6
http://m8y.org/js/sol_reduce2.xhtml  Same in FF4 and FF3.6

The issue seems to be my use of "hidden"

Apparently that triggers something in FF4 - presumably it is now some DOM node attribute.

The odd thing is it is only FF4 specific - some implementation of (X)HTML5 bleeding into XHTML 1.1?

Less sure if it is a bug now.  Although Safari and Chrome do work fine.


http://m8y.org/js/solitaire2.xhtml is the original "app" (and I use the term loosely for this evening of long ago of hacking about) with .hidden replaced with .XYZZY - works in FF4.

Comment 5

[Justin Lebar (not reading bugmail)]

Smaug, do you know if this is intentional?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Bug 567663 ?

Comment 7

[nemo]

Ah. Perhaps.  Well, the FF4 behaviour is a bit inconsistent then, since you'd think any "flipped" card (one without the face showing) would be invisible in FF4 since hidden would be true.

Certainly understandable it being honoured in older versions of HTML - heck. You don't ignore <canvas> just because it is HTML5 only...

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't understand the previous comment.

.hidden is defined by HTML5 to work as follows:

myElement.hidden = true;

should make the element no longer be displayed (act as if .style.display is set to "none").

myElement.hidden = false;

should make the element act as normal (though of course can be overridden using CSS in all the usual fashions).

Is that now how FF4 nightlies behave? .hidden was not implemented in earlier versions of Firefox, so was ignored there.

Comment 9

[nemo]

The inconsistency seems to be that some elements are not actually hidden when that is toggled.

I was using a property I had called .hidden to show/hide the text.
If you click on the diagonal row of cards, the text is shown/hidden, yet the card does not vanish.

I'm not sure why that is, but it does seem inconsistent to me.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

A minimized testcase would be great.

It seems like you are setting .hidden on <td> elements. Note that this would result in that <td> being removed, but the <td> next to it taking its place.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Nemo, what's the story on a testcase here?

Comment 12

[nemo]

Haven't started yet. probably not a big deal anyway. feel free to close it, I can alway reopen or refile if I confirm a real minified testcase for the problem mentioned in comment #9.

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sounds good. Reopening is definitely an option.