Closed
Bug 585228
Opened 14 years ago
Closed 14 years ago
Cleanup the window scriptable helper some
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(3 files)
9.55 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
6.63 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
8.12 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Now that the inner and outer windows don't share a scriptable helper, we can move some work out of the inner window.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
After this patch, we can actually make some code that calls the innerObject hook just check for its presence, which might save some perf in eval.
Attachment #463716 -
Flags: review?(jst)
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #463718 -
Flags: review?(jst)
Updated•14 years ago
|
Attachment #463715 -
Flags: review?(jst) → review+
Comment 4•14 years ago
|
||
Comment on attachment 463716 [details] [diff] [review] innerObject and outerObject should be on the outer SH and inner SH respectively - In nsOuterWindowSH::InnerObject(): nsGlobalWindow *inner = win->GetCurrentInnerWindowInternal(); if (!inner) { // Yikes! No inner window! Instead of leaking the outer window into the // scope chain, let's return an error. + // XXX Can this still happen? Maybe assert that it is so? r=jst
Attachment #463716 -
Flags: review?(jst) → review+
Updated•14 years ago
|
Attachment #463718 -
Flags: review?(jst) → review+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/36c4d4e837bb http://hg.mozilla.org/tracemonkey/rev/ce00848a1ed6 http://hg.mozilla.org/tracemonkey/rev/556eca04e304
Whiteboard: fixed-in-tracemonkey
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/36c4d4e837bb
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•