585308 - change access key for account settings to S to match main pane

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Wayne Mery (:wsmwk)]

main 3pane - Tools, S is the shortcut for Account settings
compose - Tools, C is the shortcut for Account settings

Please alter to S in the compose pane so the keys match main pane

Comment 1

[:aceman]

Does this depend on the platform?
I have these on linux:
main 3pane - Edit, A is the shortcut for Account settings (S is taken by Select)
compose - Edit, S is the shortcut for Account settings (A is taken by Select All)

Comment 2

[:aceman]

Attachment: patch for Windows

If you can test the patch (I can't build for Win), make sure there are no collisions. On Linux, S isn't yet taken in Tools.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 573961 [details] [diff] [review]
patch for Windows

Review of attachment 573961 [details] [diff] [review]:
-----------------------------------------------------------------

I like it (on Windows, that is.  On Mac, we don't seem to show or use accesskeys).  ui-r=me!

::: mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ -172,1 +172,1 @@
> >  <!ENTITY accountManagerCmdUnix.accesskey "S">

Since these are the same, do we still need them both?

Comment 4

[:aceman]

I think we should leave it for safety. As the Account settings are in different menus on Linux and Windows, there are different requirements for the accesskey. It may be needed to split them again in the future.

Comment 5

[David :Bienvenu]

Comment on attachment 573961 [details] [diff] [review]
patch for Windows

If Blake's happy with it, it's fine with me, thx for the patch.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/9c8c54d9963c