585462 - [Non-static SeaMonkey] "Warning: package error or possible missing or unnecessary file: bin/gfxutils.dll (package-manifest, 57)."

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1281263901.1281270504.21136.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/08/08 03:38:21

Warning: package error or possible missing or unnecessary file: bin/gfxutils.dll (package-manifest, 57).

-bin/gfxutils.dll
}

Probably a leftover (after a Core change), but needs to be checked/fixed.

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Probably a leftover (after a Core change)

See bug 571989 comment 31
http://hg.mozilla.org/mozilla-central/rev/75723e048528

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Stop packaging @DLL_PREFIX@gfxutils@DLL_SUFFIX@ [Checkin: Comment 3]

Ftr, I'm not adding it to removed-files.in (as this module appeared in SMv2.1a1).

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 463978 [details] [diff] [review]
(Av1) Stop packaging @DLL_PREFIX@gfxutils@DLL_SUFFIX@
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/87314367eac4

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #2)
> Ftr, I'm not adding it to removed-files.in (as this module appeared in
> SMv2.1a1).

Yet since we offer automatic updates from 2.1a1 to 2.1a2 and then to 2.1a3 it needs a removed-files.in addition.

rs+ to KaiRo to push it, if you (serge) want to patch though, I can get the review done in <24 hours.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Yet since we offer automatic updates from 2.1a1 to 2.1a2 and then to 2.1a3 it
> needs a removed-files.in addition.

Iiuc, 2.1a2 already included bug 367539.
Doesn't that cover automatic updates (too) from then on?

Comment 6

[Robert Kaiser]

At least the files AFAIK showed up as being left over on automated update tests in 2.1a2, but I don't fully remember.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> At least the files AFAIK showed up as being left over on automated update tests
> in 2.1a2, but I don't fully remember.

Hum, that case should be clarified, for now and future:
Which other files were left over?
Is this situation expected wrt bug 367539?

Comment 8

[Serge Gautherie (:sgautherie)]

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1281436537.1281554576.18976.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/08/10 03:35:37

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Remove potentially existing @DLL_PREFIX@gfxutils@DLL_SUFFIX@. [Checkin: See comment 10]

Per your request: see previous discussion though...

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 466545 [details] [diff] [review]
(Bv1) Remove potentially existing @DLL_PREFIX@gfxutils@DLL_SUFFIX@.
[Checkin: See comment 10]

http://hg.mozilla.org/comm-central/rev/488530f3266c