585863 - Investigate and fix comm-central bustage from Bug 574454

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Justin Wood (:Callek)]

There is at least static bustage (log snippet follows). and possibly shared bustage too [SM win builders are conspicuously hiding at the moment].

make[7]: Entering directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/widget/src/build'
link -NOLOGO -DLL -OUT:gkwidget.dll -PDB:gkwidget.pdb -SUBSYSTEM:WINDOWS  nsWinWidgetFactory.obj    widget.res -NXCOMPAT -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV  -IMPLIB:fake.lib  @../windows/widget_windows.lib.fake @../xpwidgets/xpwidgets_s.lib.fake   ../../../dist/lib/gkgfx.lib ../../../dist/lib/thebes.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xpcom.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xpcom_core.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/mozalloc.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/nspr4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plc4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plds4.lib  e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/unicharutil_s.lib ../../../gfx/qcms/mozqcms.lib   kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib uuid.lib ole32.lib oleaut32.lib comctl32.lib comdlg32.lib shell32.lib imm32.lib shlwapi.lib winspool.lib  
   Creating library fake.lib and object fake.exp
nsNativeThemeWin.obj : error LNK2019: unresolved external symbol __imp__GradientFill@24 referenced in function "protected: unsigned int __thiscall nsNativeThemeWin::ClassicDrawWidgetBackground(class nsIRenderingContext *,class nsIFrame *,unsigned char,struct nsRect const &,struct nsRect const &)" (?ClassicDrawWidgetBackground@nsNativeThemeWin@@IAEIPAVnsIRenderingContext@@PAVnsIFrame@@EABUnsRect@@2@Z)
gkwidget.dll : fatal error LNK1120: 1 unresolved externals
make[7]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/widget/src/build'
make[6]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/widget/src'
make[5]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/widget'
make[4]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla'
make[3]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla'
make[2]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla'
make[1]: Leaving directory `/e/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb'
make[7]: *** [gkwidget.dll] Error 96
make[6]: *** [libs] Error 2
make[5]: *** [libs] Error 2
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

This should address. Someone who can build TB should probably test though.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 464292 [details] [diff] [review]
patch

tested; and fixes my local build.

Comment 3

[Justin Wood (:Callek)]

Attachment: fix tests too.

This patch also fixes the --enable-tests case.

Comment 4

[Mark Banner (:standard8)]

I checked these in so we could get the TB builders green again:

http://hg.mozilla.org/mozilla-central/rev/3be636b90c55
http://hg.mozilla.org/mozilla-central/rev/905529619219