585946 - Location / search bar splitter moves to the end of the toolbar when toggling "tabs on top"

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Theodore]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre

The search field/location bar cannot be resized if you set tabs to be on bottom.

Reproducible: Always

Steps to Reproduce:
1. When tabs are on top, hover mouse over the divider between the location bar and search field, notice that arrows appear and the bar is resizable.
2. Right-click toolbar and uncheck "Tabs on Top" option.
3. Hover mouse over location bar/search field divider again, notice that no arrows appear and the bar is not resizable. 
Actual Results:  
Location bar/search field is not resizable.

Expected Results:  
Should be able to resize search field.

I tested this with Aero enabled. If you switch the tabs back on top, the bar is still not resizable. It only becomes resizable again if you restart the browser or right-click toolbar, choose customize, and click "Restore Default Set".

Comment 1

[Alice0775 White]

I can confirm in Aero style.
The problem does not happen in non-Aero style.

After having carried out "Customize toolbar > Done", the rersizer works again.


Regression window:
Works:
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624095420
Fails:
http://hg.mozilla.org/mozilla-central/rev/cc7c030f6b42
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624112154
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a6f3d15cfdc&tochange=cc7c030f6b42
Candidate Bug:
Bug 555081 - Can't move the window using the titlebar with custom titlebar drawing or glass areas below the titlebar

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

Seems to be Win7 only, right?

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Likely not a widget bug. This code fails to update correctly for some reason:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#2366

Maybe this is something similar to bug 555987 [{inc}Dynamically changing -moz-box-ordinal-group doesn't work].

Comment 6

[Alice0775 White]

Changing tab position causes re-binding.

  /* Make the window draggable by glassed toolbars (bug 555081) */
    ...
    #navigator-toolbox[tabsontop="false"] > #nav-bar,
    ... {
>>    -moz-binding: url("chrome://global/content/bindings/toolbar.xml#toolbar-drag");
    }

However, the binding constructor does not call UpdateUrlbarSearchSplitterState.
So this problem happens.

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Johnathan Nightingale [:johnath]]

No, johnathan, this doesn't block.

Comment 10

[Dão Gottwald [:dao]]

Attachment: better patch

Comment 11

[Bill Gianopoulos [:WG9s]]

(In reply to comment #10)
> Created attachment 513891 [details] [diff] [review]
> better patch

I find that with this new patch, in order to get the splitter to function, I have to enter/exit "Toolbar Layout" after toggling tabs-on-top.

This is with Windows 7.

Comment 12

[Neil Deakin]

Can you explain when someone would use this 'skipintoolbarset' attribute?

Also, tests should be added to test_toolbar.xul

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> Can you explain when someone would use this 'skipintoolbarset' attribute?

When adding nodes to the toolbar that aren't supposed to participate in toolbar customization, like the splitter. The (val == this.currentSet) check wouldn't work otherwise. this.currentSet would contain urlbar-search-splitter but val wouldn't.

Comment 14

[Dão Gottwald [:dao]]

Attachment: test added

Comment 16

[mcdavis941 (sporadically reading bugmail)]

Just FYI, I see this almost every day.  When I was looking into this in August (to see if it was something I was causing) I added a little CSS in Stylish to make #urlbar-search-splitter's position obvious:

#urlbar-search-splitter { background-color: lime !important; }

and I never turned that off. So, like I said, with my usage pattern, I still notice this on the order of once a day.  FWIW.

Comment 17

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Comment 18

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fe40e7c2d790

Comment 19

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/fe40e7c2d790

Comment 20

[[e-mail]]

Comment on attachment 607966 [details] [diff] [review]
patch

Bah, I knew I had forgotten somthing...

>+            if (val == this.currentSet)
>+              return;
This should return val.