Closed
Bug 586508
Opened 14 years ago
Closed 13 years ago
Improve GL error code output
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
Details
Attachments
(1 file, 1 obsolete file)
2.94 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
This annoys me everytime.
Assignee | ||
Updated•14 years ago
|
Attachment #465013 -
Attachment is patch: true
Attachment #465013 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Updated•14 years ago
|
Attachment #465013 -
Flags: review?(vladimir)
Comment on attachment 465013 [details] [diff] [review] Add error name output What, you don't know them by heart yet? :)
Attachment #465013 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Ported this to the new debug layer
Attachment #465013 -
Attachment is obsolete: true
Attachment #526066 -
Flags: review?(bjacob)
Comment 3•13 years ago
|
||
Comment on attachment 526066 [details] [diff] [review] Add error name output R+ except for this hunk which seems to have uninitentionally made it into this patch: >--- a/gfx/thebes/GLContextProviderCGL.mm >+++ b/gfx/thebes/GLContextProviderCGL.mm >@@ -161,17 +161,17 @@ public: > > default: > return nsnull; > } > } > > PRBool MakeCurrentImpl(PRBool aForce = PR_FALSE) > { >- if (!aForce && [mContext currentContext] == mContext) { >+ if (!aForce && [NSOpenGLContext currentContext] == mContext) { > return PR_TRUE; > } > > if (mContext) { > [mContext makeCurrentContext]; > } > return PR_TRUE; > }
Attachment #526066 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f1dbb031b7c5
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Assignee: nobody → matt.woodrow+bugzilla
You need to log in
before you can comment on or make changes to this bug.
Description
•