586554 - Title bar has wrong height if not maximized with custom window themes (cracked uxtheme.dll)

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect, P1)

Description

[WL]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre

In Win32 XP, when the window is not maximized, the title bar is much higher than it should be.

Reproducible: Always

Steps to Reproduce:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre
Win32 XP

Comment 1

[WL]

Attachment: maximized window

Comment 2

[WL]

Attachment: not maximized

Comment 3

[Jim Mathies [:jimm]]

(In reply to comment #2)
> Created attachment 465098 [details]
> not maximized

What type of theme / theme software are you using?

Comment 4

[WL]

Seems like you guys backed out the changes for XP in following nightly builds.
If you can read some Chinese, here is the website from where I downloaded the theme:
http://www.dzart.net/
But I can't remember exactly the one I'm using, I guess:
http://www.dzart.net/?controller=Front_Default&action=View&Id=1154

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #4)
> Seems like you guys backed out the changes for XP in following nightly builds.
> If you can read some Chinese, here is the website from where I downloaded the
> theme:
> http://www.dzart.net/
> But I can't remember exactly the one I'm using, I guess:
> http://www.dzart.net/?controller=Front_Default&action=View&Id=1154

Those landed last night. Do these need custom theme software to apply, or are they just generic windows xp themes?

Comment 6

[WL]

Those themes are packed into win32 executable,but I believe they are generic themes. Thus it may not be true as I installed 2-3 years ago.
I will check it on my XP box tomorrow.

Comment 7

[pal-moz]

Attachment: screenshot (left:maximized)

Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre ID:20100825062325

maybe your theme issue.

Comment 8

[WL]

Attachment: moz vs. opera

It's the screen shots for "Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre" and Opera, so I don't think it's a theme issue, right?

Comment 9

[pal-moz]

@WL

why don't you check with/on XP default OS Theme ?

Comment 10

[WL]

Attachment: close button only

It works fine with default theme. But current solution can't cooperate with some other custom themes while Opera handle them pretty well.

Comment 11

[pal-moz]

Attachment: screenshot (XP default Theme::Windows XP Style and Windows Classic Style)

(In reply to comment #10)
> Created attachment 469328 [details]
> close button only

it seems to be not default Theme.
it's like Vista/7 Theme.

and nothing to do with Opera or other software.
problem with 3rd party theme/software or something is not a Firefox bug.

Comment 12

[WL]

I can't agree.
Firefox are using the native widgets. How can you make a conclusion that it's an issue of 3rd party theme while the other applications work fine using the same theme?

Comment 13

[pal-moz]

maybe you think "software A (3rd party theme)" is compatible with "software B (Opera)"
so "software A" is always compatible with "software C (Minefield)"

This is not true.

your 3rd party Theme is compatible with Opera, BUT not with Minefield.

that's all.

Comment 14

[WL]

Ooooops. Let's stop spamming this bug.

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #5)
> (In reply to comment #4)
> > Seems like you guys backed out the changes for XP in following nightly builds.
> > If you can read some Chinese, here is the website from where I downloaded the
> > theme:
> > http://www.dzart.net/
> > But I can't remember exactly the one I'm using, I guess:
> > http://www.dzart.net/?controller=Front_Default&action=View&Id=1154
> 
> Those landed last night. Do these need custom theme software to apply, or are
> they just generic windows xp themes?

I couldn't find the download here for the actual windows theme files. There was a download to some exe but in an image it spammed the system with all sort of junk. If we could track down the actual theme, we could probably diagnose this.

Comment 16

[WL]

Attachment: theme tiger green

Please extract to %SystemRoot%\resources\themes.
I've scanned for viruses already, but you can also check it yourself.
Thanks.

Comment 17

[Jim Mathies [:jimm]]

(In reply to comment #16)
> Created attachment 469746 [details]
> theme tiger green
> 
> Please extract to %SystemRoot%\resources\themes.
> I've scanned for viruses already, but you can also check it yourself.
> Thanks.

Double clicking on the theme file doesn't load the theme. I'm guessing this is similar to bug 577509, which involves 3rd party themeing software. We can try to address this, but odds are it will be up to the vendor that publishes the themeing platform.

Comment 18

[WL]

Please extract to directory %SystemRoot%\resources\themes first.
You need a cracked version of uxtheme.dll (%SystemRoot%\system32\) to use 3rd party themes directly.
Shall we mark this bug as duplicated (bug 577509)?

Comment 19

[[not reading bugmail]]

(In reply to comment #18)
> Please extract to directory %SystemRoot%\resources\themes first.
> You need a cracked version of uxtheme.dll (%SystemRoot%\system32\) to use 3rd
> party themes directly.
> Shall we mark this bug as duplicated (bug 577509)?

I don't think that is needed since StarDock is a vendor in and of itself that needs to address their issues with the newest versions of Firefox.

Comment 20

[Alfred Kayser]

Added 'with custom window themes (cracked uxtheme.dll)' to the subject, as this problem only occurs with custom window themes.

Comment 21

[WL]

It works for me in latest nightly from nearly one month ago, so I think it's fixed.