586659 - Release Windows MMGC settings are unoptimized

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Werner Sharp]

Currently "Custom" Optimization and "Default" for inline function expansion is not inlining WB functions.   Switching to "Max speed" and "only __inline" significantly improves performance.  (player build config uses these settings already so this will only help the avmshell)

Comment 1

[Werner Sharp]

Attachment: fix release+release_debugger 32+64 bit configs

Switched four release configs to "maximum speed" and "only __inline" to match avmplus config settings and player settings.

Comment 2

[Edwin Smith]

Comment on attachment 465254 [details] [diff] [review]
fix release+release_debugger 32+64 bit configs

looks ok to me, might also want to check the VS2010 project.

Comment 3

[Brent Baker]

Any way that this could be applied to the x-platform build scripts?

Comment 4

[Werner Sharp]

Attachment: get 2010 working as well and fix flags

Comment 5

[Werner Sharp]

x-platform build scripts look okay:

        if config.getDebug():
            DEBUG_CXXFLAGS = "-Od "
            DEBUG_CFLAGS = "-Od "
        else:
            OPT_CXXFLAGS = "-O2 -Ob1 -GR- "
            OPT_CFLAGS = "-O2 -Ob1 -GR- "

Comment 6

[Edwin Smith]

Comment on attachment 465266 [details] [diff] [review]
get 2010 working as well and fix flags

nothing obviously wrong

Comment 7

[Werner Sharp]

http://hg.mozilla.org/tamarin-redux/rev/99d39597c36c