586748 - text-decorations are drawn through text areas

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Bug 585684 has some of the details on this problem and an example at https://bugzilla.mozilla.org/attachment.cgi?id=465037

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that this behavior is purposeful.  See http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/forms/nsTextControlFrame.cpp&rev=3.151#1589 (there's equvalent code in forms.css now) and the blame on revision 3.106 of nsTextControlFrame.cpp.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #1)
> Note that this behavior is purposeful.  See
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/forms/nsTextControlFrame.cpp&rev=3.151#1589
> (there's equvalent code in forms.css now) and the blame on revision 3.106 of
> nsTextControlFrame.cpp.

Is this the behaviour we want? It doesn't really seem useful to have text-decoration drawn on a text area.

If it is what we want, than I suppose we should fix the reftest.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Is this the behaviour we want? 

An excellent question.  I don't think it is, myself...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this is fixed by
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9dff8b867f0
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6912479afdd
and the other work in bug 403524.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #4)
Confirmed concerning https://bugzilla.mozilla.org/attachment.cgi?id=465037 against Tinderbox Win32 Build http://hg.mozilla.org/integration/mozilla-inbound/rev/088a2d2cdf33 compared to yesterday's Nightly.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Yep looks like it.

Comment 7

[Vitor Menezes]

Patch for bug 403524 makes the anonymous div inside textareas and inputs into  inline-blocks, thereby ignoring text-decorations defined outside the textarea itself.