586826 - When close all tabs in TabView, I can not return to browser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100812 Minefield/4.0b4pre ID:20100812135028
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100812 Minefield/4.0b4pre ID:20100812135028

In latest m-c hourly build, with tabcandy enabled, 
When close all tabs in TabView, I can not return to browser.


Reproducible: Always

Steps to Reproduce:
1.Create a tab group
2.Close all tabs

Actual Results:  
I can not return to browser

Expected Results:  
Should be able to return.

Comment 1

[juan becerra [:juanb]]

I can confirm this using a very recent hourly trunk build (http://hg.mozilla.org/mozilla-central/rev/c8ee0c411f5e)

Bug 586528 is related to this. It would be nice to have an easy toggle button.

Comment 2

[Raymond Lee [:raymondlee]]

This is related to this comment: 
https://bugzilla.mozilla.org/show_bug.cgi?id=576427#c3

Comment 3

[Raymond Lee [:raymondlee]]

Assigning to Aza for the design.

Comment 4

[Alice0775 White]

WORKAROUND
Create new group by drag mouse in TabView
Click icon at left-bottom of the group box
Click created New Tab

Comment 5

[Dão Gottwald [:dao]]

tabbrowser.xml line 1402 added by bug 574217 is bogus:

>1401             if (this.tabs.length - this._removingTabs.length == 1 && 
>1402                 (!TabView || !TabView.isVisible())) {
>1403               closeWindow = aCloseWindowWithLastTab != null ? aCloseWindowWithLastTab :
>1404                             !window.toolbar.visible ||
>1405                               this.tabContainer._closeWindowWithLastTab;
>1406 
>1407               // Closing the tab and replacing it with a blank one is notably slower
>1408               // than closing the window right away. If the caller opts in, take
>1409               // the fast path.
>1410               if (closeWindow &&
>1411                   aCloseWindowFastpath &&
>1412                   this._removingTabs.length == 0 &&
>1413                   (this._windowIsClosing = window.closeWindow(true)))
>1414                 return null;
>1415 
>1416               newTab = true;
>1417             }

There should never be a state where a window has zero tabs open.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> tabbrowser.xml line 1402 added by bug 574217 is bogus:

I asked Marco to back this out when he lands his stuff.

Bug 586959 is related to this.

Comment 7

[Ian Gilman [:iangilman]]

There's been some discussion about whether the window should close if you're in Tab Candy and you close the last tab. For instance, one work flow would be to close all your old tabs before starting a fresh session, and it's an extra step to create a new window first. 

That said, this fix is great for beta 4, and in fact might be the right thing overall. 

Aza, care to weigh in? Maybe start a fresh bug if we want special behavior for closing the last tab inside the Tab Candy window? Obviously if we do allow that, we'll need to make it easier to get back out of that state (including the proposed global "new tab" button).

Comment 8

[Alice0775 White]

This problem is gone in new profile, because bug 574217 has been backed out.
However, if set browser.tabs.closeWindowWithLastTab to false, this problem still happens.

Comment 9

[Alice0775 White]

(In reply to comment #8)
> This problem is gone in new profile, because bug 574217 has been backed out.
Not all of  the bug 574217, see changeset of 28f97576f0b4.

Comment 10

[Raymond Lee [:raymondlee]]

(In reply to comment #8)
> This problem is gone in new profile, because bug 574217 has been backed out.
> However, if set browser.tabs.closeWindowWithLastTab to false, this problem
> still happens.

If set browser.tabs.closeWindowWithLastTab to false, a new tab would be opened in the tab view interface and you can use it to go back to the browser view.

Comment 11

[Alice0775 White]

(In reply to comment #10)
> (In reply to comment #8)
> > This problem is gone in new profile, because bug 574217 has been backed out.
> > However, if set browser.tabs.closeWindowWithLastTab to false, this problem
> > still happens.
> 
> If set browser.tabs.closeWindowWithLastTab to false, a new tab would be opened
> in the tab view interface and you can use it to go back to the browser view.
Confirmed
Fixed by changeset 28f97576f0b4

Comment 12

[Andreea Pod]

Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110130 Firefox/4.0b11pre

If I have one tab in one group and I close the tab the window closes too but if I close the group the window doesn't closes, it opens a new tab. Shouldn't this two actions do the same thing?