Closed Bug 587730 Opened 14 years ago Closed 14 years ago

Add application/x-moz-keywordsearch URL type to yandex.xml

Categories

(Mozilla Localizations :: ru / Russian, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Keywords: productization)

Attachments

(1 file)

After bug 586821/bug 587719, the keyword URL now defaults to the default search engine's main URL, if a application/x-moz-keywordsearch URL type doesn't exist. 

Since yandex's clid parameter depends on keyword vs. search bar, the custom keyword.URL value currently in region.properties should move into yandex.xml as a application/x-moz-keywordsearch URL type.
Attached patch patchSplinter Review
On an unrelated note, I noticed that the browser.search.siteSearchURL is using the same clid value as keyword search - not sure whether that's intentional?
I don't think that's intentional, will look and verify.
I hadn't even realized this had been put in place for browser.search.siteSearchURL, tbh. If it should be in there, the CLID should be from the same as the default search plugin, not the keyword search. I'll review with Yandex and file bugs as appropriate.
Attachment #466369 - Flags: review?(unghost)
Attachment #466369 - Flags: review?(unghost) → review+
https://hg.mozilla.org/l10n-central/ru/rev/07ae2c762256
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Assignee: nobody → gavin.sharp
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: