587731 - [random orange] TEST-UNEXPECTED-FAIL | test_theme.js | false == true

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mark Banner (:standard8)]

Attachment: Full test log

We're seeing this error very frequently on the Thunderbird Linux tinderboxes:

TEST-UNEXPECTED-FAIL | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_theme.js | false == true - See following stack:
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_throw :: line 317
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_check_eq :: line 347
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_check_true :: line 359
JS frame :: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_theme.js :: anonymous :: line 283
JS frame :: resource://gre/modules/AddonManager.jsm :: safeCall :: line 42
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 589
JS frame :: resource://gre/modules/LightweightThemeManager.jsm :: anonymous :: line 375
JS frame :: resource://gre/modules/AddonManager.jsm :: callProvider :: line 70
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 587
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 117
JS frame :: resource://gre/modules/AddonManager.jsm :: AsyncObjectCaller :: line 97
JS frame :: resource://gre/modules/AddonManager.jsm :: AMI_getAddonByID :: line 595
JS frame :: resource://gre/modules/AddonManager.jsm :: AM_getAddonByID :: line 893
JS frame :: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_theme.js :: run_test_3 :: line 256
JS frame :: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_theme.js :: anonymous :: line 205
JS frame :: resource://gre/modules/AddonManager.jsm :: safeCall :: line 42
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 625
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 111
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 620
JS frame :: resource://gre/modules/AddonManager.jsm :: safeCall :: line 42
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 596
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 111
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 591
JS frame :: resource://gre/modules/PluginProvider.jsm :: PL_getAddon :: line 53
JS frame :: resource://gre/modules/AddonManager.jsm :: callProvider :: line 70
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 587
JS frame :: resource://gre/modules/AddonManager.jsm :: AOC_callNext :: line 117
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 591
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 1963
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 3382
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 2595

Full log attached, Link to tinderbox full log:

http://tinderbox.mozilla.org/showlog.cgi?tree=Thunderbird&errorparser=unittest&logfile=1281977074.1281982016.28427.gz&buildtime=1281977074&buildname=Linux%20comm-central%20check&fulltext=1

Comment 1

[Dave Townsend [:mossop]]

Probably need to up the timeout on that bit, if you attached a patch to do so, maybe to 10 seconds if that seems long enough then I'd review it. Bonus points to have it log how long it was when it does fail.

Comment 2

[Mark Banner (:standard8)]

Attachment: Extend timeouts, add extra logging

I based this on what was done with the timeouts in test_install.js.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 467739 [details] [diff] [review]
Extend timeouts, add extra logging

Awesome, thanks

Comment 4

[Mark Banner (:standard8)]

Attachment: Extend timeouts, add extra logging - for checkin

This has hg headers for easy check-in

Comment 5

[Mark Banner (:standard8)]

This is frequently seen on the Thunderbird tinderboxes, and I'm unlikely going to be able to get in a slot to land this until next week, hence adding checkin-needed.

Comment 6

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/9ec999a27d61

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed based on no more failures in the last couple of months.