58777 - Save Link to Disk Dialog Allows multiple 'File Save AS' dialogs to be opened

Status: NEW

(Firefox :: File Handling, defect)

Description

[Sean Chitwood]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001023
BuildID:    20001023

After choosing a link that cannot be displayed in mozilla, you are prompted to
open with a Helper App or save to disk. If you select save to disk you can open
as many Windows 'Save As...' dialog as you want if you follow this procedure

Reproducible: Always
Steps to Reproduce:
1) Find a link to MP3 or QuickTime File on the web
2) CLick on the link, when prompted to download or open choose download.
3) With the WIndows 'Save As' Dialog still up, go back to the Mozilla dialog and
Click Ok again and again and again...

Actual Results:  Multiple WIndows File Save as Dialog boxes....

Expected Results:  No additional File Save as Dialog Boxes

Comment 1

[bergee-bugzilla]

Confirmed using:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20001031 (trunk 
build) On Win2k

Probably belongs under "XP Apps: GUI Features" component.

Comment 2

[Sean Chitwood]

There was some discussion in IRC about whether this was a bug. The opinions were:

1) This maximises user choice so shouldn't be fixed (But another bug about the
crash actually using those Save As Dialogs causes should be filed.)

2) (My opinion) That saving the file to disk like the second stage of a wizard
[Sorry for the MSism] and there should be only 1 second screen, not unlimited.

Comment 3

[Asa Dotzler [:asa]]

over to XPApps

Comment 4

[Viswanath Ramachandran]

Unless we see a spec saying this shd be the desired behaviour, we should not fix
this bug. 

Comment 5

[Blake Ross]

Reopening, we need to fix this.  This dialog should be modal, no?

Comment 6

[Matthew T (active 1999-2002)]

Yes, the Save filepicker should be modal to that particular browser window. (It 
should not be modal to the what-shall-I-do dialog, as that dialog should have 
gone away before the filepicker opens.)

Comment 7

[sairuh (rarely reading bugmail)]

spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)

Comment 8

[:deanis74]

"It should not be modal to the what-shall-I-do dialog, as that dialog should have 
gone away before the filepicker opens."

Ideally that's one option, but that probably would require a large rewrite to fix.

Another fix that's probably much quicker is to make the filepicker modal to the
Open/Save dialog.  There should be nothing stopping me from going back to the
original browser window, as by this point it's not concerned with the download
anymore.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 148139 has been marked as a duplicate of this bug. ***

Comment 10

[Andrei Boros]

Possibly related to this bug (should I report a new one?) :

url is an image only (not html with embedded images)
saveing won't popup the save as dialog until the image has finished loading.
(ctrl-S, file->save as, right click Save Image as)

Behaviour possibly related to #84123 (image information is shown in titlebar
only after image finishes loading).

And also, if there are multiple save requests while image is loading, when load
finishes, multiple save as dialogs will appear.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

happens on linux too

Comment 12

[Matthias Urlichs]

Oh boy, a 21-year old bug. For the record, this is still a problem. It can't be that difficult to not open more than one of these at the same time??

Even worse: when I'm typing some sensitive password as the dialog happens to pop up, presto people see the tail of the password and the file is stored with that name.

Comment 13

[Matthias Urlichs]

NB, this can happens easily when I click on a download link and the server replies late / there are already N on-going downloads.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 15

[:Gijs (he/him)]

In Firefox 98 we no longer show the "what do you want to do with this file" dialog by default so the priority of this is much lower, tbh.