587907 - Remove ability to instantiate a RasterImage by contract ID

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

mozilla-central only instantiates a RasterImage by contract ID in one place -- in imgRequest.cpp, which could just as easily do "new RasterImage()".

Is there any reason we need to even allow creation of RasterImage by contract ID? If not, it seems like extra code that we can & should remove.

Comment 1

[Bobby Holley (:bholley)]

(In reply to comment #0)
> mozilla-central only instantiates a RasterImage by contract ID in one place --
> in imgRequest.cpp, which could just as easily do "new RasterImage()".
> 
> Is there any reason we need to even allow creation of RasterImage by contract
> ID?

Nope - we should get rid of it. It should probably wait until I land my big patch stack at bug 513681, since that changes a lot of the nsImageModule stuff.