587980 - Wrong definition in CSS for Thunderbird

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Richard Marti (:Paenglab)]

On creating a patch for Thunderbird (Bug 545557) I've found a bug in Personas:

#messengerWindow[persona] #tabmail, .tabmail-tabs {
  background-color:transparent !important;
}

The comma after #tabmail should be removed. Like it is now .tabmail-tabs background-color is always transparent also when no persona is applied. With removing this comma all works as expected.

This definition is used in linux (line 70), winxp and vista (both line 80).

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch fixing this issue

Chris I nowhere found who is the right person for r?, so I take you.

Comment 2

[Chris Beard]

dmose?

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

I asked dmose about this earlier in the week, and he suggested andreas.  cc'ing him now.

Comment 4

[Andreas Nilsson (:andreasn)]

Comment on attachment 530289 [details] [diff] [review]
Patch fixing this issue

I could not reproduce this issue (probably because lwthemes are build into Thunderbird now), but the patch applies cleanly to the personas checkout and looking at the css the comma have no place in there.

Comment 5

[Matthew N. [:MattN]]

https://hg.mozilla.org/labs/personas/rev/cd6e8e8ccecc

Thanks for the patch!