588788 - Make /featured RSS feed validate

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Make https://preview.addons.mozilla.org/z/en-US/firefox/featured/format:rss validate:

http://feedvalidator.org/check.cgi?url=https%3A%2F%2Fpreview.addons.mozilla.org%2Fz%2Fen-US%2Ffirefox%2Ffeatured%2Fformat%3Arss

Comment 1

[Robert Helmer [:rhelmer]]

"guid must be a full URL, unless isPermaLink attribute is false: /z/en-US/firefox/addon/2455/versions/2.0.0.4 (33 occurrences)"

Absolutified the URL in http://github.com/rhelmer/zamboni/commit/81da955348b0949663046fe3e4af7eb0f7104e16

"Self reference doesn't match document location" (recommendation) 

This is because the link is HTTPS; I need to dig into this a bit more but the document should be equivalent so I think it's OK.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to comment #1)
> "Self reference doesn't match document location" (recommendation) 
> 
> This is because the link is HTTPS; I need to dig into this a bit more but the
> document should be equivalent so I think it's OK.

Note that http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fpreview.addons.mozilla.org%2Fz%2Fen-US%2Ffirefox%2Ffeatured%2Fformat%3Arss does not have that warning, just to clarify.

Comment 3

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/780e6fe

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, thanks!