589015 - js_watch_set doesn't need that crazy dummy frame

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm

When there is both a watchpoint and setter on the same property, the result of the watchpoint is passed to the setter.  As Blake explained: back in the day, before the age of wrapperization, there was a potential security hole whereby, e.g., content watchpoints could inject content values into chrome setters.  That was the problem fixed by the dummy frame.  With wrappers, though, there should be no such mingling and thus this dummy frame is no longer necessary.  It's also a massive breaker of invariants I'd like to have for bug 539144.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 467615 [details] [diff] [review]
rm

Woo-hoo!

Comment 2

[Brendan Eich [:brendan]]

I managed to dis-remember this dis-gusting history. Kill this code with fire, salt the earth, drive it before you and hear the lamentation da wimmin!

/be

Comment 3

[Luke Wagner [:luke]]

Indeed, that is best in life.

http://hg.mozilla.org/tracemonkey/rev/b22e82ce2364

Comment 4

[Brendan Eich [:brendan]]

http://www.youtube.com/watch?v=OBGOQ7SsJrw

/be

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/b22e82ce2364