Closed
Bug 589114
Opened 14 years ago
Closed 13 years ago
Use frame scheduling for animated Fullscreen toolbar hiding
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: ts.bugzilla, Assigned: dao)
References
Details
(Keywords: perf, polish, Whiteboard: [snappy])
Attachments
(1 file, 4 obsolete files)
|
4.21 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3) Gecko/20100805 Firefox/4.0 Build Identifier: Follow-up according to https://bugzilla.mozilla.org/show_bug.cgi?id=240859#c39 > The animation should be replaced with the new css transition, reducing the > custom animation code for this fullscreen autohide function. Reproducible: Always
|
Assignee | |
Comment 1•14 years ago
|
||
Morphing. mozRequestAnimationFrame provides the same benefits as CSS animations but leaves more control to the script.
Summary: Use CSS Transition for Fullscreen toolbar show/hide → Use frame scheduling for animated Fullscreen toolbar hiding
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
Component: Toolbars → General
QA Contact: toolbars → general
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
more s/FullScreen/this/
Attachment #468001 -
Attachment is obsolete: true
Attachment #468022 -
Flags: review?(mano)
Attachment #468001 -
Flags: review?(mano)
|
||
Comment 4•13 years ago
|
||
Dao, is there any perf win to be had by moving to CSS or is this just for code maintainability?
This is currently the jerkiest of the UI animations for me and I believe that mozRequestAnimationFrame should help with that. Also, this bug has the perf keyword. I think after 10+ months it's probably time to look for another reviewer.
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [snappy]
|
|
Assignee | |
Comment 6•13 years ago
|
||
updated to tip
Attachment #468022 -
Attachment is obsolete: true
Attachment #585017 -
Flags: review?(dolske)
Attachment #468022 -
Flags: review?(mano)
|
|
Assignee | |
Comment 7•13 years ago
|
||
oops, I didn't pay enough attention when merging
Attachment #585017 -
Attachment is obsolete: true
Attachment #585018 -
Flags: review?(dolske)
Attachment #585017 -
Flags: review?(dolske)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #585018 -
Flags: review?(dietrich)
|
||
Comment 8•13 years ago
|
||
Comment on attachment 585018 [details] [diff] [review] patch Review of attachment 585018 [details] [diff] [review]: ----------------------------------------------------------------- looks good, r=me. i <3 bind().
Attachment #585018 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #585018 -
Flags: review?(dolske)
|
|
Assignee | |
Comment 9•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/2843998a1579
Target Milestone: --- → Firefox 12
|
||
Comment 10•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2843998a1579
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 11•13 years ago
|
||
The animation is also cancelled in enterDomFullScreen, which was missed. If preferred, we can re-close this & just file a followup.
Attachment #587407 -
Flags: review?(dao)
|
|
||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 12•13 years ago
|
||
(In reply to Paul O'Shannessy [:zpao] from comment #11) > If preferred, we can re-close this & just file a followup. Please do.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Attachment #587407 -
Attachment is obsolete: true
Attachment #587407 -
Flags: review?(dao)
You need to log in
before you can comment on or make changes to this bug.
Description
•