589140 - [Firefox Menu Button]Position of the bookmark is strange and does not correctly update.

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100820033948
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100820033948

After drag and drop bookmarks, the position of the bookmark is strange.
You can confirm the correct position in Library.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Create Bookmarks/folders and placed within "Bookmarks Menu"
3. Open Bookmarks popup ( "Firefox Menu" > "Bookmarks >"　)
4. Drag & drop bookmark/folder

Actual Results:
 Position of the bookmark which I dragged & dropped is strange.
 You can confirm the correct position in Library.

Expected Results:
 The bookmark should be at the position of the indicator

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

What do you mean by "strange"? Does this bug reply only pertain to the Firefox Button?

Comment 2

[Alice0775 White]

(In reply to comment #1)
> What do you mean by "strange"? Does this bug reply only pertain to the Firefox
> Button?

After drag and drop bookmark within the bookmark popup of Firefox Button,the dropped bookmark appears wrong position.

Comment 3

[Alice0775 White]

This problem happens due to adding items into placesView, after construction of _placesView (new PlacesMenu).

              <menupopup id="appmenuBookmarkMenu_popup"
                         placespopup="true"
                         context="placesContext"
                         openInTabs="children"
                         oncommand="BookmarksEventHandler.onCommand(event);"
                         onclick="BookmarksEventHandler.onClick(event);"
                         onpopupshowing="BookmarksMenuButton.onPopupShowing(event);
                                         if (!this.parentNode._placesView)new PlacesMenu(event, 'place:folder=BOOKMARKS_MENU');
>>                                      this.appendChild(document.getElementById('appmenuBookmarkMenu_unsorted_seperator'));
>>                                      this.appendChild(document.getElementById('appmenuBookmarkMenu_unsorted-menuitem'));"
                         tooltip="bhTooltip"
                         popupsinherittooltip="true">

Comment 4

[Alice0775 White]

Still happens on
http://hg.mozilla.org/mozilla-central/rev/198709160138
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre ID:20100922041040

Comment 5

[Justin Dolske [:Dolske]]

Bug 592900 probably fixes this.

Comment 6

[Marco Bonardo [:mak]]

it's also possible there is a bug due to hiding bookmarks toolbar submenu and separator, but we should fix the other bug before (as dolske said, it was wrong in the first place to use appendChild that way) and than test for that.

Comment 7

[Marco Bonardo [:mak]]

As far as I can test everything seems to be working fine after the patch in bug 592900, please reopen if you see remaining issues.