Closed
Bug 589827
Opened 14 years ago
Closed 14 years ago
Vector interp shift performance 7% slower than array
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cpeyer, Assigned: stejohns)
References
Details
Attachments
(1 file)
|
357.71 KB,
patch
|
wsharp
:
review+
|
Details | Diff | Splinter Review |
Performance is consistently 7% slower than array with -Dinterp. Performance is equivalent when run with jit. Test is located in asteam/hg/qe/projects/performance/tests/language/vector/shift.abc
Flags: flashplayer-qrb?
|
||
Updated•14 years ago
|
Assignee: nobody → stejohns
Flags: flashplayer-qrb? → flashplayer-qrb+
|
Assignee | |
Comment 1•14 years ago
|
||
Make shift a native method; with this patch, the testcase is about 5% faster that Array.shift in interp mode.
Attachment #484186 -
Flags: review?(wsharp)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 484186 [details] [diff] [review] Patch Looks fine besides the fact that is based upon the avmplus list implementation of vector so doesn't quite match what's in TR currently.
Attachment #484186 -
Flags: review?(wsharp) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Yeah, it can't land till that one does, just an end-of-day quickie patch.
|
|
Assignee | |
Comment 4•14 years ago
|
||
TR 5421:e7f070d39ffd
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•