Closed
Bug 589910
Opened 14 years ago
Closed 14 years ago
Notifications don't work in the sidebar
Categories
(SeaMonkey :: Sidebar, defect)
SeaMonkey
Sidebar
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
(Keywords: fixed-seamonkey2.0.9, regression)
Attachments
(1 file)
2.62 KB,
patch
|
iannbugzilla
:
review+
kairo
:
approval-seamonkey2.0.9+
|
Details | Diff | Splinter Review |
At some point, probably soon after we implemented notifications, since I know I would have tested it at the time, and it fails in an old 2.0pre/Gecko1.9.1pre build, the <browser> element got changed such that it now has a non-null docShell property even when it is hidden. This means that notifications in the sidebar don't actually work :-( Steps to reproduce problem: javascript:sidebar.addPanel('Popup Test', 'http://www.popuptest.com/popuptest1.html', null);
Assignee | ||
Comment 1•14 years ago
|
||
I also took the opportunity to move the button(s) between the icon and the close button. This often saves space in the common case, and I used an arrowscrollbox to stop the sidebar looking too bad in the multiple button case. Geolocation is a particularly bad example, try the following: javascript:sidebar.addPanel("Demo: geolocation", "http://html5demos.com/geo", null); (note that this "works" in the sidebar without the patch, because the geolocation notification code accesses the notificationbox directly.)
Comment on attachment 468444 [details] [diff] [review] Proposed patch r=me
Attachment #468444 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #468444 -
Flags: approval-seamonkey2.0.7?
Assignee | ||
Comment 3•14 years ago
|
||
Pushed changeset 262c8f5ec24d to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 4•14 years ago
|
||
Comment on attachment 468444 [details] [diff] [review] Proposed patch I'm pretty sure we don't have any add-ons or such hooking into sidebar notifications, but else the <binding> change wouldn't be too good on a stable branch. In this case, I guess it's OK.
Attachment #468444 -
Flags: approval-seamonkey2.0.7? → approval-seamonkey2.0.7+
Comment 5•14 years ago
|
||
Comment on attachment 468444 [details] [diff] [review] Proposed patch 2.0.7 has been shipped, transferring approval to 2.0.8 instead.
Attachment #468444 -
Flags: approval-seamonkey2.0.7+ → approval-seamonkey2.0.8+
Assignee | ||
Comment 6•14 years ago
|
||
Pushed changeset e1bb865fb450 to releases/comm-1.9.1
Keywords: fixed-seamonkey2.0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•