Closed Bug 590054 Opened 14 years ago Closed 14 years ago

fix cross-architecture pointer size serialization problem with Cocoa NPAPI events

Categories

(Core Graveyard :: Plug-ins, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(blocking2.0 beta7+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

The Cocoa NPAPI event structure contains pointers which will be of different sizes on i386 and x86_64. This means message size expectations will not match when sending an event from an x86_64 parent to an i386 child.
Blocks: 559142
Attached patch fix v1.0Splinter Review
Attachment #468909 - Flags: review?(b56girard)
Attachment #468909 - Flags: review?(jones.chris.g)
Comment on attachment 468909 [details] [diff] [review]
fix v1.0

r=me for the chromium stuff, didn't look at the NPEvent changes.
Attachment #468909 - Flags: review?(jones.chris.g) → review+
Comment on attachment 468909 [details] [diff] [review]
fix v1.0

r+ on the NPCocoaEvent changes.
Attachment #468909 - Flags: review?(b56girard) → review+
blocking2.0: --- → beta6+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6f2fd17d789a
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: