590390 - DeCOM nsICharsetAlias

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Makoto Kato [:m_kato]]

This interface should be simple C-style helper function.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: for m-c

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So, what's this patch waiting for?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #2)
> So, what's this patch waiting for?

Since this causes API break, after 2.0 branching, I will set a review flag.

Comment 4

[Marco Castelluccio [:marco]]

A reviewer is needed for this patch.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 468907 [details] [diff] [review]
for m-c

Indeed, 2.0 has shipped for a couple of days now. Simon?

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 468907 [details] [diff] [review]
for m-c

The patch is bitrotted, not surprisingly after all this time, but it looks good in principal. I would love to review an updated version.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: fix v2

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 600309 [details] [diff] [review]
fix v2

Review of attachment 600309 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 9

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2893c5e0be5d

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/2893c5e0be5d

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This caused bug 737966. Kato-san, could you attach a fix there.