Closed Bug 590708 Opened 14 years ago Closed 13 years ago

test_Prototype.html | testAsynchronousRequest - 1 assertions, 0 failures, 1 errors

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: humph, Assigned: justin.lebar+bug)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch - Disable (well, delete) testAsynchronousRequest
1.55 KB, patch
jst
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282765398.1282767255.24869.gz

s: talos-r3-leopard-045
5135 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/prototype/test_Prototype.html | testAsynchronousRequest - 1 assertions, 0 failures, 1 errors
TypeError: null has no properties(TypeError: null has no properties)
Summary: intermittent orange: test_Prototype.html | testAsynchronousRequest - 1 assertions, 0 failures, 1 errors → test_Prototype.html | testAsynchronousRequest - 1 assertions, 0 failures, 1 errors
The particular failure here appears simple enough:

  testAsynchronousRequest: function() {
    this.assertEqual("", $("content").innerHTML);
    
    new Ajax.Request("../fixtures/hello.js", extendDefault({
      asynchronous: true,
      method: 'get',
      evalJS: 'force'
    }));
    this.wait(1000, function() {
      var h2 = $("content").firstChild;
      this.assertEqual("Hello world!", h2.innerHTML);
    });
  },

I tried fixing this by moving the assertion into an onComplete handler, but that handler was never invoked for some reason.  Anyway, I'm sure we could figure this out.

But this file looks like a total minefield overall.  There are no fewer than five separate tests which use a timeout of 1000ms.

Ehsan, Clint, Dave: How would you feel if we just removed this test?  I can't imagine that it's adding much value in its current state.
Attachment #534301 - Flags: review?(dcamp)
Comment on attachment 534301 [details] [diff] [review]
Patch - Disable (well, delete) testAsynchronousRequest

I don't really know anything about this test, jst can you review or hand off appropriately please?
Attachment #534301 - Flags: review?(dcamp) → review?(jst)
Attachment #534301 - Flags: review?(jst) → review+
One down...

http://hg.mozilla.org/mozilla-central/rev/d07c9f9e6489
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee: nobody → justin.lebar+bug
Whiteboard: [orange]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: