590939 - Log uploader fails on try talos runs

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris AtLee [:catlee]]

Because no 'who' property is set. e.g.

2010-08-26 08:49:04-0700 [Broker,9,10.250.50.47] Error running ['/tools/buildbot-0.8.0/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py', 'stage.mozilla.org', '-u', 'ffxbld', '-i', '/home/cltbld/.ssh/ffxbld_dsa', '-b', 'tryserver', '-p', 'linux', '--try', '/builds/buildbot/tests-master/tryserver_fedora_test-chrome', '26']
2010-08-26 08:49:04-0700 [Broker,9,10.250.50.47] Log output: Traceback (most recent call last):
          File "/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py", line 165, in <module>
            who=build.getProperty('who'),
          File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/status/builder.py", line 1149, in getProperty
            return self.properties[propname]
          File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/process/properties.py", line 45, in __getitem__
            rv = self.properties[name][0]
        KeyError: 'who'

Comment 1

[Chris AtLee [:catlee]]

Attachment: Try harder to find author for try jobs

Talos jobs don't get 'who' set, so this patch makes it so the log uploader falls back to the change's author.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 469500 [details] [diff] [review]
Try harder to find author for try jobs

Looks good to me!

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 469500 [details] [diff] [review]
Try harder to find author for try jobs

changeset:   911:f91ce1e881ab