591101 - bholley testing bug for git-bz

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Bobby Holley (:bholley)]

I've changed the QA contact - if anybody gets bugmail from this, please let me know and I'll figure out how to stop spamming you.

Comment 1

[Bobby Holley (:bholley)]

Attachment: test patch

Trying it out

Review: [e-mail]

Comment 2

[Bobby Holley (:bholley)]

Attachment: try 2

trying again.

Comment 3

[Bobby Holley (:bholley)]

Attachment: try 3

Third time's the charm

Comment 4

[Bobby Holley (:bholley)]

Attachment: colon test

This is to see if I can flag for :bholley

Comment 5

[Bobby Holley (:bholley)]

Attachment: final test

This test involves selecting multiple reviewers, selecting a super-reviewer, and mixing colon notation with regular bugmails.

If you get flagged for review by this, it means I can flag for review when pushing to bugzilla! Oh happy day.

Comment 6

[Daniel Holbert [:dholbert]]

r+sr=dholbert!!

Comment 7

[Phil Ringnalda (:philor)]

I'll get bugmail for it every night that it's open, since I have a query for bugs that don't have the right QA contact, but I eat bugspam for breakfast.

Comment 8

[Bobby Holley (:bholley)]

(In reply to comment #7)
> I'll get bugmail for it every night that it's open, since I have a query for
> bugs that don't have the right QA contact, but I eat bugspam for breakfast.

I'll just close it for now then, and reopen it when I need it again.

Comment 9

[Bobby Holley (:bholley)]

Attachment: patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560

Comment 10

[Bobby Holley (:bholley)]

Attachment: patch v2

Comment 11

[Bobby Holley (:bholley)]

Attachment: patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560

Comment 12

[Bobby Holley (:bholley)]

Attachment: patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560

Comment 13

[Bobby Holley (:bholley)]

Attachment: patch v2

https://bugzilla.mozilla.org/show_bug.cgi?id=591560

Comment 14

[Bobby Holley (:bholley)]

Looks like git-bz was broken by FF4, so I've got some more testing to do.

Buckle up philor. ;-)

Comment 15

[Bobby Holley (:bholley)]

Attachment: Bug 653930 - Tests. v1

Comment 16

[Bobby Holley (:bholley)]

Attachment: Bug 653930 - v1

Comment 17

[Bobby Holley (:bholley)]

Comment on attachment 530531 [details] [diff] [review]
Bug 653930 - v1

Review of attachment 530531 [details] [diff] [review]:

overall comments.

more overall comments.

::: content/base/src/nsFrameLoader.cpp
@@ +865,5 @@
+void
+nsFrameLoader::MarginsChanged(PRUint32 aMarginWidth,
+                              PRUint32 aMarginHeight)
+{
+  // We assume that the margins are always zero for remote frames.

test comment

@@ +875,5 @@
+  // margins.
+  if (!mDocShell)
+    return;
+
+  // Set the margins

another test comment

::: content/base/src/nsFrameLoader.h
@@ +209,5 @@
 
   /**
+   * Called when the margin properties of the containing frame are changed.
+   */
+  void MarginsChanged(PRUint32 aMarginWidth, PRUint32 aMarginHeight);

last test comment

Comment 18

[Bobby Holley (:bholley)]

All is well. Re-closing.

Comment 19

[Bobby Holley (:bholley)]

good evening :-)

Comment 20

[Phil Ringnalda (:philor)]

I actually switched that whine mail to monthly, and then stopped paying any attention to it, so if you want to just leave it open that's fine by me.

Comment 21

[Bobby Holley (:bholley)]

Attachment: Some nonsense from benoit.

Comment 22

[Bobby Holley (:bholley)]

(In reply to Phil Ringnalda (:philor) from comment #20)
> I actually switched that whine mail to monthly, and then stopped paying any
> attention to it, so if you want to just leave it open that's fine by me.

but the metrics! ;-)

Comment 23

[Bobby Holley (:bholley)]

Attachment: More benoit nonsense.

Comment 24

[Bobby Holley (:bholley)]

Attachment: Makoto magic!

Comment 25

[Bobby Holley (:bholley)]

Attachment: First banner patch.

Comment 26

[Bobby Holley (:bholley)]

Attachment: Banner patch 0.

Comment 27

[Bobby Holley (:bholley)]

Attachment: Banner patch 1.

Comment 28

[Bobby Holley (:bholley)]

Until next time!

Comment 29

[Bobby Holley (:bholley)]

Attachment: Replace the scripted closing unblocker termination function with an runnable. v1

The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.

Comment 30

[Bobby Holley (:bholley)]

Attachment: Replace the scripted closing unblocker termination function with an runnable. v1

The main idea behind this thing seems to be that we don't want script to quickly
close the window before the user has time to read the notification. Given the
fuzziness of the constraint here, I think we can (and maybe even should) unblock
a little bit later in the event loop, rather than immediately after the script
terminates.

Comment 31

[Andrew McCreight [:mccr8]]

comment

Comment 32

[Andrew McCreight [:mccr8]]

Comment on attachment 578695 [details] [diff] [review]
Banner patch 0.

comment

Comment 33

[Andrew McCreight [:mccr8]]

Comment on attachment 742580 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

comment

Comment 34

[Andrew McCreight [:mccr8]]

Comment on attachment 742575 [details] [diff] [review]
Replace the scripted closing unblocker termination function with an runnable. v1

test

Comment 35

[Andrew McCreight [:mccr8]]

Attachment: Element.

comment

Comment 36

[Andrew McCreight [:mccr8]]

Attachment: Element.

Comment 37

[Andrew McCreight [:mccr8]]

Attachment: Element.

Comment 38

[Andrew McCreight [:mccr8]]

Attachment: Example file move with git.