Closed
Bug 591481
Opened 14 years ago
Closed 14 years ago
Bump maxVersion of Feedback for beta6
Categories
(Firefox :: Extension Compatibility, defect)
Firefox
Extension Compatibility
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: mossop, Assigned: johnath)
References
Details
Attachments
(1 file)
1.29 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
We may want to just make it 4.0.* at this point but we must remember to do it.
Reporter | ||
Updated•14 years ago
|
Assignee: nobody → dtownsend
blocking2.0: beta5+ → beta6+
Assignee | ||
Comment 1•14 years ago
|
||
This should do it? (Are we making a habit of bumping the testpilot version number, too? I noticed you did for the b5 version of this patch.) [Aside: do we have a bug blocking final to turn feedback off?]
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 473623 [details] [diff] [review] Bump compat to 4.0.* (In reply to comment #1) > Created attachment 473623 [details] [diff] [review] > Bump compat to 4.0.* > > This should do it? (Are we making a habit of bumping the testpilot version > number, too? I noticed you did for the b5 version of this patch.) I've been bumping the version in the past but in this cases no changes have actually landed for feedback so no version change seems necessary. > [Aside: do we have a bug blocking final to turn feedback off?] We do now, bug 594858
Attachment #473623 -
Flags: review?(dtownsend) → review+
Comment 3•14 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/75f87884fa18
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Target Milestone: --- → Firefox 4.0b6
Comment 4•14 years ago
|
||
This needs to land on the GECKO20b5_20100831_RELBRANCH ASAP.
Comment 5•14 years ago
|
||
Pushed to the relbranch: http://hg.mozilla.org/mozilla-central/rev/633e895d5e84
Comment 6•14 years ago
|
||
Could we please preprocess the install.rdf file to insert MOZ_APP_VERSION, so we don't have to remember this. eg http://mxr.mozilla.org/mozilla-central/source/browser/locales/generic/install.rdf http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/install.rdf.in
Comment 7•14 years ago
|
||
Don't think it's needed anymore, since we just made the maxVer 4.0.*
Comment 8•14 years ago
|
||
Unless you want to ship it in 4.x or 5.x...
You need to log in
before you can comment on or make changes to this bug.
Description
•