591544 - [1.9.1] test_CF_HTML_clipboard.html is perma-orange with "SimpleTest.waitForFocus is not a function"

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Holbert [:dholbert]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1282941921.1282944723.14877.gz
OS X 10.5.2 mozilla-1.9.1 test mochitests on 2010/08/27 13:45:21
s: moz2-darwin9-slave55
{
44652 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - SimpleTest.waitForFocus is not a function
}

Also affects the last 2 logs
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1282753500.1282756650.4149.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1282684691.1282686965.9322.gz

... and the logs before that are all orange, so I think they're also affected, but I haven't loaded them individually.

Based on the failure message, it looks like this test assumes functionality that we don't have on 1.9.1.  I'd guess that it's been permaorange ever since it was checked in (on July 30th, in http://hg.mozilla.org/releases/mozilla-1.9.1/rev/af24f6ef65b4 )

Ehsan, mind investigating?

(Note: I originally blamed bug 580151 -- the most recent push -- for this, until I noticed that it also affected the previous tinderbox cycle, a few days ago)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

I guess we should just use addLoadEvent...

Comment 3

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/99f51ed48a27

Comment 4

[(no longer active)]

I also landed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/22d43c7ca110 as a followup so that the test actually passes on 1.9.1!

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1283191547.1283195008.15439.gz
OS X 10.5.2 mozilla-1.9.1 test mochitests on 2010/08/30 11:05:47
44643 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - SimpleTest.waitForFocus is not a function

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1283267476.1283270580.31910.gz
OS X 10.5.2 mozilla-1.9.1 test mochitests on 2010/08/31 08:11:16
44638 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Test timed out.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1283280865.1283283611.24624.gz
OS X 10.5.2 mozilla-1.9.1 test mochitests on 2010/08/31 11:54:25

V.Fixed

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Verified fixed for 1.9.1 based on passing automated test.