Open Bug 591561 Opened 14 years ago Updated 2 years ago

GfxInfo's checks for Dwrite/D2D must be called after gfxPlatform init

Categories

(Core :: Graphics, defect)

x86
macOS
defect

Tracking

()

People

(Reporter: jrmuizel, Unassigned)

Details

Currently we initialize GfxInfo before gfxPlatform init. If the functions that check Dwrite/D2D are called at this time we'll crash. This should probably be fixed by having the d2d/dwrite detection code set a property on GfxInfo instead of having GfxInfo query it.
Version: unspecified → Trunk
This appears to still be the case.
gfxPlatform isn't initialized before GfxInfo, but it appears that it would be initialized in time if somebody was to attempt calling one of the GfxInfo::GetD2DEnabled or GfxInfo::GetDWriteEnabled methods. They both go through GetPlatform() method, which calls gfxPlatform::Init() before returning, so it looks like we would be OK.  Non-withstanding the suggestion to change it to "detection code set a property" approach.
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(jmuizelaar)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.