Closed
Bug 592009
Opened 14 years ago
Closed 13 years ago
AppendPrintf truncates output to 31 ASCII characters
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file, 1 obsolete file)
|
4.50 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I got caught by this in bug 586048
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
This time I've done a quick audit of all the users and none of them look performance critical, thus I've made AppendPrintf31 private.
Attachment #470521 -
Attachment is obsolete: true
Attachment #554433 -
Flags: review?(benjamin)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 554433 [details] [diff] [review] Use vsmprintf to overcome this limitation v2 It appears to me that nsTSubstring_CharT::AppendPrintf leaks its buffer: doesn't it need to call PR_smprintf_free on it? r=me with that change
Attachment #554433 -
Flags: review?(benjamin) → review+
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/548e34a4a9c2
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•