592020 - js_Disassemble1 output for JOF_UINT16PAIR

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P2)

Description

[Eric Hennigan]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.4; Linux) KHTML/4.4.2 (like Gecko) Kubuntu
Build Identifier: 


The js_Disassemble1() output for JOF_UINT16PAIR bytecodes is incorrect.

Reproducible: Always

Steps to Reproduce:
1. disassemble any script that uses a JOF_UINT16PAIR bytecode, for example the defsharp opcode:

function  foo() { return #1=[a]; }
print(dis(foo))

Actual Results:  
flags: NULL_CLOSURE
main:
00000:  trace
00001:  newinit 3
00003:  sharpinit 0
00006:  defsharp 0 0
00011:  zero
00012:  name "a"
00015:  initelem
00016:  sharpinit 0
00019:  endinit
00020:  return
00021:  stop

Source notes:
undefined

Expected Results:  
flags: NULL_CLOSURE
main:
00000:  trace
00001:  newinit 3
00003:  sharpinit 0
00006:  defsharp 0 1
00011:  zero
00012:  name "a"
00015:  initelem
00016:  sharpinit 0
00019:  endinit
00020:  return
00021:  stop

Source notes:
undefined

Comment 1

[Eric Hennigan]

Attachment: patch to fix disassemble output for JSOF_UINT16PAIR

Comment 2

[André Bargull [:anba]]

Resolving as WFM - JOF_UINT16PAIR was removed some time ago.