Closed
Bug 592560
Opened 14 years ago
Closed 14 years ago
Port changes from toolkit's browser_354894.js to SeaMonkey's browser_bug515006.js
Categories
(SeaMonkey :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
|
5.79 KB,
patch
|
neil
:
review+
misak.bugzilla
:
feedback+
|
Details | Diff | Splinter Review |
There have been various changes to toolkit's test browser_354894.js which we should probably port to SeaMonkey's test browser_bug515006.js
Attachment #470997 -
Flags: feedback?(misak.bugzilla)
|
||
Updated•14 years ago
|
Attachment #470997 -
Flags: feedback?(misak.bugzilla) → feedback+
Attachment #470997 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 470997 [details] [diff] [review] Port the changes patch v0.1 [Checked in: Comment 2] >- if (gPrefService.prefHasUserValue(pref)) { >+ if (gPrefService.prefHasUserValue(pref)) > gPrefService.clearUserPref(pref); >- } > } > gPrefService.setBoolPref("browser.tabs.warnOnClose", oldWarnTabsOnClose); [Odd, they forgot to switch to Services.prefs!] I haven't actually tried this but the changes look reasonable to me.
Attachment #470997 -
Flags: review?(neil) → review+
Comment on attachment 470997 [details] [diff] [review] Port the changes patch v0.1 [Checked in: Comment 2] http://hg.mozilla.org/comm-central/rev/cd6208fd054a Included change to use Services.prefs as suggested.
Attachment #470997 -
Attachment description: Port the changes patch v0.1 → Port the changes patch v0.1 [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 3•14 years ago
|
||
Could you s/browser_bug515006.js/browser_354894.js/ while here?
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•