592719 - Code-coverage - AS3 Classes: Error

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Tools, defect, P4)

Description

[Chris Peyer]

as of redux r5139:

                        covered      total        covered    total      
class                 functions  functions   pct     cond     cond   pct
Error                         9         16  56.2        3        6  50.0

coverage of:

avmplus::ErrorClass::
avmplus::ErrorObject::

Comment 1

[Brent Baker]

Attachment: Additional coverage for Error

Coverage data generated running the following acceptance runs with a release-debugger build of the shell.

Acceptance Runs:
./runtests.py as3/Statements/Exceptions as3/RuntimeErrors as3/ErrorObject ecma3/Exceptions ecma3/ErrorObject 
./runtests.py --vmargs=-Dnodebugger as3/Statements/Exceptions as3/RuntimeErrors as3/ErrorObject ecma3/Exceptions ecma3/ErrorObject 

Coverage classes: (covselect -l)
exclude all /
exclude folder ../../../tamarin-redux/
include source ../../../tamarin-redux/core/ErrorClass.cpp
include source ../../../tamarin-redux/core/ErrorClass.h

Coverage Results: (covclass -m)
Class                            Function Coverage           C/D Coverage
---------------------------  ---------------------  ---------------------
avmplus::                        11 /    11 = 100%       5 /     6 =  83%
avmplus::ErrorClass::             5 /     5 = 100%       0 /     0       
avmplus::ErrorObject::            4 /     4 = 100%       5 /     6 =  83%
avmplus::NativeErrorClass::       2 /     2 = 100%       0 /     0       
---------------------------  ---------------------  ---------------------
Total                            11 /    11 = 100%       5 /     6 =  83%

Additional testcase is simply to cover getStackTrace() within a known testcase. This is currently covered elsewhere in the suite, but this makes coverage easier to reproduce.

Add an acceptance pass in code coverage to pick up code paths available when debugger is compiled in BUT not enabled (via -Dnodebugger)

Comment 2

[Dan Schaffer]

Comment on attachment 484324 [details] [diff] [review]
Additional coverage for Error

- what does -Dnodebugger add to code coverage?
- I would have made the test smaller by just included the try/catch finally part of the test and not used getTestCases since there is only 1 test. but that is just me.

Comment 3

[Brent Baker]

(In reply to comment #2)
> Comment on attachment 484324 [details] [diff] [review]
> Additional coverage for Error
> 
> - what does -Dnodebugger add to code coverage?

There are branches in the VM that check to see if a debugger is attached and they will only be compiled in if the build is debugger. So the -Dnodebugger gives the 'true' coverage of the following:
       63         #ifdef DEBUGGER
       64         AvmCore *core = this->core();
       65         if (!core->debugger())
       66             return;

Comment 4

[Brent Baker]

Comment on attachment 484324 [details] [diff] [review]
Additional coverage for Error

Patch pushed as 5373:fde08035a073

Comment 5

[Trevor Baker]

can close?

Comment 6

[Dan Smith]

Brent, can this be closed?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.