592897 - perplexing experience when closing windows in Panorama [tabcandy-central]

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P4)

Description

[juan becerra [:juanb]]

http://hg.mozilla.org/try/rev/08d6e565ab29 Sept 1 tryserver build

Closing tabs can be a little confusing in Panorama. I was trying out Panorama's awareness of all tabs in all windows, when I got into a situation where I was prompted whether I wanted to close several tabs, when I was only trying to kill one window. Simply, I felt confused.

Steps:
1. Open two windows. Open several tabs in one of them.
2. Go into Panorama mode in both windows.
3. Create a group and drag the single tab in the first window onto it
4. Select the tab from step 3
5. Click on the close window icon

Expected: I should be able to close the window with no prompt to close several other tabs.

Actual: I get a message saying whether I want to close several tabs.

What's more, if I do select to close them, and I end up with no windows (the case at the moment), if I open another window and go into Panorama mode, I will see several blank tabs in a group corresponding at least in number to the group of tabs I closed.

At worse, it might not be handling my session data correctly.

This one is sort of special, so I will not refrain from asking to block despite it not being in mozilla-central.

Comment 1

[Dietrich Ayala (:dietrich)]

Blocking+, since it's part of the all-windows in tabview work in bug 578512, which is blocking.

Comment 2

[Aza Raskin [:aza]]

Hey Juan,

I'm confused as to your description. I think we should separate out the "Are you sure" message into a separate bug. The rest I think are just interim bugs that mitcho is working on (apparently we aren't as solid as we should be for the multi-window case).

Also see: https://bugzilla.mozilla.org/show_bug.cgi?id=576427#c27

Comment 3

[Dietrich Ayala (:dietrich)]

swapping beta blocker flag because all-windows is canceled for this release.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Dietrich, did you intend to remove the blocking+? It still says blocking+ here for me.

Also, is this a dupe of bug 587245?

Comment 5

[Ian Gilman [:iangilman]]

I think the point here is that in "all windows", we need to make sure to move the hidden tabs to another window when the user closes the window they're hosted in. In that way it's not a dupe of bug 587245, but it's also not relevant until we have bug 578512 back in the picture; punting to the future.

Comment 6

[Ian Gilman [:iangilman]]

(also removed the blocking flag, which was dietrich's stated intention... not sure if that's the proper process)

Comment 7

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.