593267 - Legacy user images don't show up if they aren't PNGs

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Zamboni hard codes user images as .png (both in the USER_PIC_* settings and in the UserProfile model).  The good news is, if people upload new images, they are converted to be a .png.  The bad news is, old images aren't.

We should convert the old images to pngs.

Comment 1

[Wil Clouser [:clouserw]]

in the script that looks for these files, it should check if $userid.png exists already, and if so just remove the .jpg or .gif.  Otherwise, convert the old image to .png and remove it.

Comment 2

[Wil Clouser [:clouserw]]

http://github.com/jbalogh/zamboni/commit/d3a8a4ae6921a20e22061036e40e753b4ec03dd4, will run with next push

Comment 3

[Wil Clouser [:clouserw]]

I just ran this on PAMO.  See

https://addons.mozilla.org/en-US/firefox/user/9945/

vs

https://preview.addons.mozilla.org/en-US/firefox/user/9945/

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

My understanding is that we (WebQA) should wait for bug 595247, then have Wil re-run the script on PAMO, before verifying.

Comment 5

[Wil Clouser [:clouserw]]

You can verify it right now if you want.  I'm just saying that when that bug runs, it'll reset this, but until it runs, this bug is fixed.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> You can verify it right now if you want.  I'm just saying that when that bug
> runs, it'll reset this, but until it runs, this bug is fixed.

Thx; since bug 595247 is now fixed, mind re-running the script?

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #6)
> (In reply to comment #5)
> > You can verify it right now if you want.  I'm just saying that when that bug
> > runs, it'll reset this, but until it runs, this bug is fixed.
> 
> Thx; since bug 595247 is now fixed, mind re-running the script?

He said it wouldn't be done for a few hours

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

I spun off a bug for fligtar's pic, which still isn't showing up on prod: bug 596477.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.