593787 - Long click on any Bookmark in Bookmark Manager doesn't always pop up context menu with the options "Edit" and "Remove"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b5) Gecko/20100101 Firefox/4.0b5
Build Identifier: Build Identifier: Mozilla /5.0 (Android;Linux armv7l; rv:2.0b6pre)Gecko/20100905 Firefox/4.0b6pre Fennec /2.0b1pre

In the Bookmark Manager, the long click on a bookmark doesn't always pop up teh context menu so the bookmark can be removed or edited
Reproducibility is 90%

Reproducible: Sometimes

Steps to Reproduce:
1.Bookmark some more sites that the default ones
2.Enter Bookmark manager
3.Long click on any Bookmark
Actual Results:  
Long click on any Bookmark in Bookmark Manager doesn't always pop up context menu with the options "Edit" and "Remove"

Expected Results:  
Long click on any Bookmark in Bookmark Manager it pops up the context menu with the options "Edit" and "Remove"

Comment 1

[Aakash Desai [:aakashd]]

I see this as well. One thing to add to this: the row entry highlights on every tap, but the context menu does not pop-up. The behavior comes in waves (i.e. if it happens once, it happens a few more times before the functionality works again on another random bookmark).

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

IMO, this is related to the fact that we are not synchronized with the ui.dragThresholdX/ui.dragThresholdY preferences and so when you touch a row and pan a little bit (5px) the context menu event is cancelled, while we need 25px to dismiss the blue highlight.

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#1972

The patch turns both prefs to 25px and use it into the InputHandler.js code.

The patch is low risk.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/3fd1b8c80cd5

Comment 4

[Ayan Shah[:ashah]]

Verified on :

Build: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b6pre)Gecko/20100909 Firefox/4.0b6pre Fennec /2.0b1pre

Comment 5

[Aaron Train [:aaronmt]]

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12893