593916 - leading zeroes on revisions are lost in application.ini

Status: NEW

(Firefox Build System :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Symptoms: on TBPL, builds but not tests/talos showing for surkov's m-c rev 015684940860. On inspection the tests/talos have 15684940860 marked as the revision.

json-pushes:
 "15535": {
  "date": 1283828161, 
  "changesets": [
   "015684940860c96d8d9c4232efcb66b413aec469"
  ], 
  "user": "[e-mail]"
 }, 

For the 10.5.2 opt build, properties:
got_revision	015684940860c96d8d9c4232efcb66b413aec469
revision	015684940860c96d8d9c4232efcb66b413aec469
sourcestamp	15684940860

Sendchanges went with the leading 0, and show up OK test builds (revision property is right). The get_build_info step outputs:
TinderboxPrint:<a href=http://hg.mozilla.org/mozilla-central/rev/15684940860 title="Built from revision 15684940860">rev:15684940860</a>

That's the main problem, although the sourcestamp property on the build is also worth investigation.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

From application.ini on the linux build:
 SourceStamp=15684940860

Someone's treating it as an int rather than a str.

Comment 2

[(not currently active) Ted Mielczarek]

I thought I fixed this in bug 581516, is it still recurring?

Comment 3

[(not currently active) Ted Mielczarek]

Oh, crap, this is a slightly different problem.

Comment 4

[(not currently active) Ted Mielczarek]

So the problem is just that the leading zero is being dropped. :-/ Preprocessor.py tries to be smart and if a preprocessor define is all digits, it parses it as an int. Since this revision is all digits, it gets parsed as an int, and then when it's serialized, the leading zero is dropped.

*sigh*

Comment 5

[Benjamin Smedberg]

I think this behavior of preprocessor.py is all wrong. All variables should be integers. When we try to treat them as numbers (e.g. using comparison operators) we should then try to parse them as numbers.

The only case where this might change current behavior is the == operator, which is apparently overloaded to be string-equality and number-equality currently (http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#3045).