Closed
Bug 593922
Opened 14 years ago
Closed 14 years ago
Unused variable and initializer ordering compiler warnings with wasPreloadNone, mPreloadAction
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: cajbir, Assigned: cpearce)
Details
Attachments
(1 file)
|
2.72 KB,
patch
|
cajbir
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
Bug 548523 landed introducing these compiler warnings: content/html/content/src/nsHTMLMediaElement.cpp: In member function ‘void nsHTMLMediaElement::UpdatePreloadAction()’: content/html/content/src/nsHTMLMediaElement.cpp:874: warning: unused variable ‘wasPreloadNone’ ../../../../dist/include/nsHTMLMediaElement.h: In constructor ‘nsHTMLMediaElement::nsHTMLMediaElement(already_AddRefed<nsINodeInfo>, PRUint32)’: ../../../../dist/include/nsHTMLMediaElement.h:677: warning: ‘nsHTMLMediaElement::mShuttingDown’ will be initialized after ../../../../dist/include/nsHTMLMediaElement.h:577: warning: ‘nsHTMLMediaElement::PreloadAction nsHTMLMediaElement::mPreloadAction’ content/html/content/src/nsHTMLMediaElement.cpp:1270: warning: when initialized here See bug 548523 comment 24 where they were mentioned but must have been missed when the bug was re-landed.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → chris
Attachment #473925 -
Flags: review?(chris.double)
|
Reporter | |
Updated•14 years ago
|
Attachment #473925 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 473925 [details] [diff] [review] Patch Requesting approval2.0 for this patch. It's a safe patch to take.
Attachment #473925 -
Flags: approval2.0?
Attachment #473925 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ed0b52948de6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•