Closed Bug 594011 Opened 14 years ago Closed 14 years ago

test_history_store shoudn't use hardcoded timestamps

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file)

If the history entries are too old, the history engine's queries won't find them anymore as we only query the last 30 days.
Attached patch v1Splinter Review
Assignee: nobody → philipp
Attachment #472619 - Flags: review?(mconnor)
Attachment #472619 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/c18a3d025902
Blocks: 590633
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
how do we get this landed on mozilla-central for the xpcshell tests?
(In reply to comment #3)
> how do we get this landed on mozilla-central for the xpcshell tests?

We hope to merge again real soon (bug 590633). If that's not soon enough, we can land this individual fix sooner.
would it be ok to land the changes to this specific file as part of another patch in bug 591325 (fixing a regression from bug 586754)?
(In reply to comment #5)
> would it be ok to land the changes to this specific file as part of another
> patch in bug 591325 (fixing a regression from bug 586754)?

You could just import my patch into your queue... ;)
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: